Fixed a bug where chrome crash omits crash time stamp after it's sent.

Fixed a bug where chrome crash omits crash time stamp after it's sent.

This cl patches in the solution devised by phistuck@gmail.com. See bug 664430 for detail.

BUG=664430
Committed: https://crrev.com/d8027b2065994c2a5b8cbea2821971dc60b7c6f5
Cr-Commit-Position: refs/heads/master@{#438333}

[Jia, 2016-12-13 01:47:10]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 01:47:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jia, 2016-12-13 03:23:38]

Description was changed from

==========
Fixed a bug where chrome crash omits crash time stamp after it's sent.

BUG=664430
==========

to

==========
Fixed a bug where chrome crash omits crash time stamp after it's sent.

BUG=664430
==========

[Jia, 2016-12-13 03:23:38]

jiameng@chromium.org changed reviewers:
+ rsesek@chromium.org

[commit-bot: I haz the power, 2016-12-13 03:24:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 03:24:00]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2016-12-13 16:19:40]

LGTM

[Robert Sesek, 2016-12-13 16:20:08]

May also want to put a line in the CL description to credit
phistuck@chromium.org.

[Jia, 2016-12-13 23:13:38]

Description was changed from

==========
Fixed a bug where chrome crash omits crash time stamp after it's sent.

BUG=664430
==========

to

==========
Fixed a bug where chrome crash omits crash time stamp after it's sent. 

This cl patches in the solution devised by phistuck@gmail.com. See bug 664430
for detail.

BUG=664430
==========

[Jia, 2016-12-13 23:16:04]

On 2016/12/13 16:20:08, Robert Sesek wrote:
> May also want to put a line in the CL description to credit
> mailto:phistuck@chromium.org.

Thanks for pointing out! It was my oversight, as I thought the link to the
associated bug already contains all the detail of the original solution and the
owner of the solution, I should have been clearer. :)

[Jia, 2016-12-13 23:16:15]

The CQ bit was checked by jiameng@chromium.org

[Jia, 2016-12-13 23:16:53]

Thanks!

[commit-bot: I haz the power, 2016-12-13 23:16:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 23:26:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481670975474690, "parent_rev":
"308cb8968e7ea273021ddb8b5d6a7c432f758caf", "commit_rev":
"20df3aeb296fccb7fe68543e65d2342dc17ec100"}

[commit-bot: I haz the power, 2016-12-13 23:26:37]

Description was changed from

==========
Fixed a bug where chrome crash omits crash time stamp after it's sent. 

This cl patches in the solution devised by phistuck@gmail.com. See bug 664430
for detail.

BUG=664430
==========

to

==========
Fixed a bug where chrome crash omits crash time stamp after it's sent. 

This cl patches in the solution devised by phistuck@gmail.com. See bug 664430
for detail.

BUG=664430

Review-Url: https://codereview.chromium.org/2568953003
==========

[commit-bot: I haz the power, 2016-12-13 23:26:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 23:29:17]

Description was changed from

==========
Fixed a bug where chrome crash omits crash time stamp after it's sent. 

This cl patches in the solution devised by phistuck@gmail.com. See bug 664430
for detail.

BUG=664430

Review-Url: https://codereview.chromium.org/2568953003
==========

to

==========
Fixed a bug where chrome crash omits crash time stamp after it's sent.

This cl patches in the solution devised by phistuck@gmail.com. See bug 664430
for detail.

BUG=664430

Committed: https://crrev.com/d8027b2065994c2a5b8cbea2821971dc60b7c6f5
Cr-Commit-Position: refs/heads/master@{#438333}
==========

[commit-bot: I haz the power, 2016-12-13 23:29:18]

Patchset 1 (id:??) landed as
https://crrev.com/d8027b2065994c2a5b8cbea2821971dc60b7c6f5
Cr-Commit-Position: refs/heads/master@{#438333}

[PhistucK, 2016-12-16 09:39:55]

On 2016/12/13 23:29:18, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/d8027b2065994c2a5b8cbea2821971dc60b7c6f5
> Cr-Commit-Position: refs/heads/master@{#438333}

I used the same <ph name="CRASH_TIME">, that may be the issue.
Can you change the second one to <ph name="UPLOAD_TIME">?

[Wez, 2016-12-27 22:28:34]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2601853002/ by wez@chromium.org.

The reason for reverting is: See crbug.com/674249: This change broke things in
two ways:
- The string format incorrectly uses the crash-time parameter twice, rather than
the second parameter coming from upload-time.
- The string format assumes that all crashes have a valid crash-time, which is
not the case for Breakpad reports..