Revert of Supervised Users: Create ResourceThrottle only if filtering is enabled

Revert of Supervised Users: Create ResourceThrottle only if filtering is enabled (patchset #3 id:40001 of https://codereview.chromium.org/2564043002/ )

Reason for revert:
This is believed to have increased the rate of failure for SupervisedUserContentProviderTest#testWithSupervisedUser on linux_android_rel_ng.

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20%28with%20patch%29&builder=tryserver.chromium.android%3Alinux_android_rel_ng for dramatic increase in failure rate after this CL landed.

Example failure: https://chromium-swarm.appspot.com/task?id=330d0f66aec28810

Original issue's description:
> Supervised Users: Create ResourceThrottle only if filtering is enabled
>
> Before this CL, we were creating a SupervisedUserResourceThrottle for
> each top-level navigation. If the current user isn't supervised, this is
> pointless. One side-effect was that we were recording
> ManagerUsers.Filter* histograms for all navigations, including for
> non-supervised users.
>
> This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
> to true iff the user is supervised. This allows us to not create the
> resource throttle for regular users.
>
> BUG=671472
>
> Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
> Cr-Commit-Position: refs/heads/master@{#437868}

TBR=bauerb@chromium.org,treib@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671472
Committed: https://crrev.com/ac24b64ae94c5950d4452c28ca834e156ed4275a
Cr-Commit-Position: refs/heads/master@{#437910}

[bpastene, 2016-12-12 20:26:47]

The CQ bit was checked by bpastene@chromium.org

[bpastene, 2016-12-12 20:26:47]

Created Revert of Supervised Users: Create ResourceThrottle only if filtering is
enabled

[commit-bot: I haz the power, 2016-12-12 20:27:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 20:29:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481574407422310, "parent_rev":
"def2bede6a6b7e4cb222b678dd0d2e0a55eb5d79", "commit_rev":
"d44984ac71319e512a3a6ccc726950587db705b6"}

[commit-bot: I haz the power, 2016-12-12 20:30:20]

Description was changed from

==========
Revert of Supervised Users: Create ResourceThrottle only if filtering is enabled
(patchset #3 id:40001 of https://codereview.chromium.org/2564043002/ )

Reason for revert:
This is believed to have increased the rate of failure for
SupervisedUserContentProviderTest#testWithSupervisedUser on
linux_android_rel_ng.

See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
for dramatic increase in failure rate after this CL landed.

Example failure: https://chromium-swarm.appspot.com/task?id=330d0f66aec28810

Original issue's description:
> Supervised Users: Create ResourceThrottle only if filtering is enabled
> 
> Before this CL, we were creating a SupervisedUserResourceThrottle for
> each top-level navigation. If the current user isn't supervised, this is
> pointless. One side-effect was that we were recording
> ManagerUsers.Filter* histograms for all navigations, including for
> non-supervised users.
> 
> This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
> to true iff the user is supervised. This allows us to not create the
> resource throttle for regular users.
> 
> BUG=671472
> 
> Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
> Cr-Commit-Position: refs/heads/master@{#437868}

TBR=bauerb@chromium.org,treib@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671472
==========

to

==========
Revert of Supervised Users: Create ResourceThrottle only if filtering is enabled
(patchset #3 id:40001 of https://codereview.chromium.org/2564043002/ )

Reason for revert:
This is believed to have increased the rate of failure for
SupervisedUserContentProviderTest#testWithSupervisedUser on
linux_android_rel_ng.

See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
for dramatic increase in failure rate after this CL landed.

Example failure: https://chromium-swarm.appspot.com/task?id=330d0f66aec28810

Original issue's description:
> Supervised Users: Create ResourceThrottle only if filtering is enabled
> 
> Before this CL, we were creating a SupervisedUserResourceThrottle for
> each top-level navigation. If the current user isn't supervised, this is
> pointless. One side-effect was that we were recording
> ManagerUsers.Filter* histograms for all navigations, including for
> non-supervised users.
> 
> This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
> to true iff the user is supervised. This allows us to not create the
> resource throttle for regular users.
> 
> BUG=671472
> 
> Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
> Cr-Commit-Position: refs/heads/master@{#437868}

TBR=bauerb@chromium.org,treib@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671472

Review-Url: https://codereview.chromium.org/2568953002
==========

[commit-bot: I haz the power, 2016-12-12 20:30:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 20:56:53]

Description was changed from

==========
Revert of Supervised Users: Create ResourceThrottle only if filtering is enabled
(patchset #3 id:40001 of https://codereview.chromium.org/2564043002/ )

Reason for revert:
This is believed to have increased the rate of failure for
SupervisedUserContentProviderTest#testWithSupervisedUser on
linux_android_rel_ng.

See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
for dramatic increase in failure rate after this CL landed.

Example failure: https://chromium-swarm.appspot.com/task?id=330d0f66aec28810

Original issue's description:
> Supervised Users: Create ResourceThrottle only if filtering is enabled
> 
> Before this CL, we were creating a SupervisedUserResourceThrottle for
> each top-level navigation. If the current user isn't supervised, this is
> pointless. One side-effect was that we were recording
> ManagerUsers.Filter* histograms for all navigations, including for
> non-supervised users.
> 
> This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
> to true iff the user is supervised. This allows us to not create the
> resource throttle for regular users.
> 
> BUG=671472
> 
> Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
> Cr-Commit-Position: refs/heads/master@{#437868}

TBR=bauerb@chromium.org,treib@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671472

Review-Url: https://codereview.chromium.org/2568953002
==========

to

==========
Revert of Supervised Users: Create ResourceThrottle only if filtering is enabled
(patchset #3 id:40001 of https://codereview.chromium.org/2564043002/ )

Reason for revert:
This is believed to have increased the rate of failure for
SupervisedUserContentProviderTest#testWithSupervisedUser on
linux_android_rel_ng.

See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
for dramatic increase in failure rate after this CL landed.

Example failure: https://chromium-swarm.appspot.com/task?id=330d0f66aec28810

Original issue's description:
> Supervised Users: Create ResourceThrottle only if filtering is enabled
>
> Before this CL, we were creating a SupervisedUserResourceThrottle for
> each top-level navigation. If the current user isn't supervised, this is
> pointless. One side-effect was that we were recording
> ManagerUsers.Filter* histograms for all navigations, including for
> non-supervised users.
>
> This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
> to true iff the user is supervised. This allows us to not create the
> resource throttle for regular users.
>
> BUG=671472
>
> Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
> Cr-Commit-Position: refs/heads/master@{#437868}

TBR=bauerb@chromium.org,treib@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671472

Committed: https://crrev.com/ac24b64ae94c5950d4452c28ca834e156ed4275a
Cr-Commit-Position: refs/heads/master@{#437910}
==========

[commit-bot: I haz the power, 2016-12-12 20:56:54]

Patchset 1 (id:??) landed as
https://crrev.com/ac24b64ae94c5950d4452c28ca834e156ed4275a
Cr-Commit-Position: refs/heads/master@{#437910}

[Marc Treib, 2016-12-14 13:27:28]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2578533002/ by treib@chromium.org.

The reason for reverting is: Going to address the problems in the reland CL..