Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2568943002: [stubs] Fix negative index lookup in hasOwnProperty (Closed)

Created:
4 years ago by Jakob Kummerow
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix negative index lookup in hasOwnProperty ...and HasProperty, for dictionary-elements receivers. BUG=chromium:673008 Committed: https://crrev.com/bb753b6dd72e0d132456983248c8f695a692f25d Cr-Commit-Position: refs/heads/master@{#41656}

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M src/builtins/builtins-object.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-673008.js View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Jakob Kummerow
PTAL.
4 years ago (2016-12-12 19:32:34 UTC) #4
Dan Ehrenberg
lgtm
4 years ago (2016-12-12 20:00:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568943002/20001
4 years ago (2016-12-12 20:10:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 20:12:26 UTC) #13
Igor Sheludko
lgtm
4 years ago (2016-12-12 20:21:44 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-12 20:26:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb753b6dd72e0d132456983248c8f695a692f25d
Cr-Commit-Position: refs/heads/master@{#41656}

Powered by Google App Engine
This is Rietveld 408576698