Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2568933003: Fix media_router_bindings.js for binary messaging. (Closed)

Created:
4 years ago by miu
Modified:
4 years ago
Reviewers:
imcheng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix media_router_bindings.js for binary messaging. Mojo JS codegen provides binary data in objects of type Array<number>, not Uint8Array. This change fixes the assumption, and provides the required Uint8Array to the provider handler function. Committed: https://crrev.com/6582d0b551556bb7793daf855d994c2ec864ddb3 Cr-Commit-Position: refs/heads/master@{#438025}

Patch Set 1 #

Total comments: 2

Patch Set 2 : !Array<number> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M extensions/renderer/resources/media_router_bindings.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
miu
imcheng: PTAL.
4 years ago (2016-12-13 01:27:18 UTC) #2
imcheng
lgtm https://codereview.chromium.org/2568933003/diff/1/extensions/renderer/resources/media_router_bindings.js File extensions/renderer/resources/media_router_bindings.js (right): https://codereview.chromium.org/2568933003/diff/1/extensions/renderer/resources/media_router_bindings.js#newcode719 extensions/renderer/resources/media_router_bindings.js:719: * @param {!Array} data Should this be !Array<number> ...
4 years ago (2016-12-13 01:40:34 UTC) #3
miu
https://codereview.chromium.org/2568933003/diff/1/extensions/renderer/resources/media_router_bindings.js File extensions/renderer/resources/media_router_bindings.js (right): https://codereview.chromium.org/2568933003/diff/1/extensions/renderer/resources/media_router_bindings.js#newcode719 extensions/renderer/resources/media_router_bindings.js:719: * @param {!Array} data On 2016/12/13 01:40:34, imcheng wrote: ...
4 years ago (2016-12-13 03:11:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568933003/20001
4 years ago (2016-12-13 03:11:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 03:27:46 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 03:29:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6582d0b551556bb7793daf855d994c2ec864ddb3
Cr-Commit-Position: refs/heads/master@{#438025}

Powered by Google App Engine
This is Rietveld 408576698