Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2568913002: Merge to m56: Fix broken panel menus (Closed)

Created:
4 years ago by David Tseng
Modified:
4 years ago
Reviewers:
David Tseng
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge to m56: Fix broken panel menus Regressed by https://codereview.chromium.org/2443103004 The code missed the fact that |node| changes value outside of the Closure and so doesn't actually refer to the expected node (i.e. |node| is always the last node in the AX tree). TEST=use the menus; press enter over an item and make sure things actually work. BUG=671778 TBR=dtseng@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2556893002 Cr-Commit-Position: refs/heads/master@{#437009} (cherry picked from commit f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f) Committed: https://chromium.googlesource.com/chromium/src/+/9d327e75089cac3ab510b434b763d81f67f0b74e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
David Tseng
4 years ago (2016-12-12 18:58:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d327e75089cac3ab510b434b763d81f67f0b74e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698