Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2556893002: Fix broken panel menus (Closed)

Created:
4 years ago by David Tseng
Modified:
4 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken panel menus Regressed by https://codereview.chromium.org/2443103004 The code missed the fact that |node| changes value outside of the Closure and so doesn't actually refer to the expected node (i.e. |node| is always the last node in the AX tree). TEST=use the menus; press enter over an item and make sure things actually work. BUG=671778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f Cr-Commit-Position: refs/heads/master@{#437009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
David Tseng
Missed during original codereview; ptal.
4 years ago (2016-12-06 21:23:16 UTC) #4
dmazzoni
lgtm
4 years ago (2016-12-07 06:33:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556893002/1
4 years ago (2016-12-07 16:58:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 18:20:52 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 18:23:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9c3cdff4cfb0c39f8bc6ced9faaed038804d23f
Cr-Commit-Position: refs/heads/master@{#437009}

Powered by Google App Engine
This is Rietveld 408576698