Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2568883005: ImageCapture v4l2: reset user controls when opening the device (Closed)

Created:
4 years ago by mcasas
Modified:
4 years ago
Reviewers:
emircan
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageCapture v4l2: reset user controls when opening the device ToT resets the control values to their default upon StopAndDeallocate() of the device, but, as the bug says, sometimes Chrome is shut down unexpectedly or -shivers- crashes. This CL moves the resetting to AllocateAndStart() method. BUG=662616 Committed: https://crrev.com/7c87eca4bdc531431eafa66c37e9468b1ccb5ca6 Cr-Commit-Position: refs/heads/master@{#438389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/capture/video/linux/v4l2_capture_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
mcasas
emircan@ tiny change, PTAL
4 years ago (2016-12-14 00:10:43 UTC) #2
emircan
lgtm
4 years ago (2016-12-14 00:20:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568883005/1
4 years ago (2016-12-14 00:58:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 02:05:47 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-14 02:08:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c87eca4bdc531431eafa66c37e9468b1ccb5ca6
Cr-Commit-Position: refs/heads/master@{#438389}

Powered by Google App Engine
This is Rietveld 408576698