Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2568883003: Revert of Add ubsan_no_recover_hack to missing ubsan builders. (Closed)

Created:
4 years ago by inferno
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ubsan_no_recover_hack to missing ubsan builders. (patchset #1 id:1 of https://codereview.chromium.org/2538103002/ ) Reason for revert: UBSan is noisy and can't be enabled for explicit crash behavior on builders. On ClusterFuzz, it will be still enabled to create testcases. BUG=673488 Original issue's description: > Add ubsan_no_recover_hack to missing ubsan builders. > > R=inferno@chromium.org, ochang@chromium.org, phajdan.jr@chromium.org > BUG=669566 > > Committed: https://crrev.com/a50c295543d07efaedd8534d117f3860a3df52e8 > Cr-Commit-Position: refs/heads/master@{#435317} TBR=ochang@chromium.org,phajdan.jr@chromium.org,mmoroz@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=669566 Committed: https://crrev.com/587155a2669951ced6f9e9c2db8d9ee09abcd670 Cr-Commit-Position: refs/heads/master@{#438074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
inferno
Created Revert of Add ubsan_no_recover_hack to missing ubsan builders.
4 years ago (2016-12-13 04:48:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568883003/1
4 years ago (2016-12-13 04:48:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 06:07:53 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 06:10:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/587155a2669951ced6f9e9c2db8d9ee09abcd670
Cr-Commit-Position: refs/heads/master@{#438074}

Powered by Google App Engine
This is Rietveld 408576698