Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2568863003: Split out argument parser construction in run-binding-tests. (Closed)

Created:
4 years ago by dglazkov
Modified:
4 years ago
Reviewers:
Dirk Pranke, peria
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split out argument parser construction in run-binding-tests. Also cleaned up the code a bit. R=peria BUG=673213 Committed: https://crrev.com/d7a90171831f3fbc6d48b862c75b8cae110bcf9d Cr-Commit-Position: refs/heads/master@{#438168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M third_party/WebKit/Tools/Scripts/run-bindings-tests View 2 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dglazkov
PTAL.
4 years ago (2016-12-13 05:39:19 UTC) #3
peria
lgtm
4 years ago (2016-12-13 05:43:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568863003/1
4 years ago (2016-12-13 15:01:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 15:06:37 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d7a90171831f3fbc6d48b862c75b8cae110bcf9d Cr-Commit-Position: refs/heads/master@{#438168}
4 years ago (2016-12-13 15:08:13 UTC) #13
Dirk Pranke
4 years ago (2016-12-15 03:01:01 UTC) #15
Message was sent while issue was closed.
lgtm also.

Powered by Google App Engine
This is Rietveld 408576698