Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 2568843002: [ObjC ARC] Converts ios/chrome/browser/ui/elements:elements to ARC. (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/elements:elements to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/b806e2846fc469062fb5c5cf2b36969b3463d6b1 Cr-Commit-Position: refs/heads/master@{#438861}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Patch Set 3 : missing_include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -48 lines) Patch
M ios/chrome/browser/ui/elements/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/elements/selector_coordinator.mm View 3 chunks +10 lines, -18 lines 0 comments Download
M ios/chrome/browser/ui/elements/selector_picker_presentation_controller.mm View 2 chunks +5 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/elements/selector_picker_view_controller.mm View 1 2 7 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
stkhapugin
PTAL
4 years ago (2016-12-12 19:03:57 UTC) #6
sdefresne
lgtm https://codereview.chromium.org/2568843002/diff/1/ios/chrome/browser/ui/elements/selector_picker_view_controller.mm File ios/chrome/browser/ui/elements/selector_picker_view_controller.mm (right): https://codereview.chromium.org/2568843002/diff/1/ios/chrome/browser/ui/elements/selector_picker_view_controller.mm#newcode132 ios/chrome/browser/ui/elements/selector_picker_view_controller.mm:132: ? (UILabel*)view Please change this to ObjCCastStrict<UILabel>(view)
4 years ago (2016-12-12 19:22:34 UTC) #7
stkhapugin
Thanks https://codereview.chromium.org/2568843002/diff/1/ios/chrome/browser/ui/elements/selector_picker_view_controller.mm File ios/chrome/browser/ui/elements/selector_picker_view_controller.mm (right): https://codereview.chromium.org/2568843002/diff/1/ios/chrome/browser/ui/elements/selector_picker_view_controller.mm#newcode132 ios/chrome/browser/ui/elements/selector_picker_view_controller.mm:132: ? (UILabel*)view On 2016/12/12 19:22:34, sdefresne wrote: > ...
4 years ago (2016-12-13 13:08:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568843002/20001
4 years ago (2016-12-13 13:08:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/123099)
4 years ago (2016-12-13 13:14:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568843002/40001
4 years ago (2016-12-15 16:27:30 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-15 17:34:11 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-15 17:35:55 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b806e2846fc469062fb5c5cf2b36969b3463d6b1
Cr-Commit-Position: refs/heads/master@{#438861}

Powered by Google App Engine
This is Rietveld 408576698