Control TaskScheduler initialization params in renderers via field trial.

Control TaskScheduler initialization params in renderers via field trial.

BUG=664996
Review-Url: https://codereview.chromium.org/2568793003
Cr-Commit-Position: refs/heads/master@{#442109}
Committed: https://chromium.googlesource.com/chromium/src/+/1e3963fb07388dd5175f9e2d7bcd7ee1e3c8f134

[fdoray, 2016-12-12 16:36:46]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2016-12-12 16:36:47]

PTAL

[gab, 2016-12-12 17:33:33]

Cool :), is this what the metrics folks recommended?

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:129: if
(ContainsSeparator(key_value.first) ||
Wrap in #if DCHECK_IS_ON() and NOTREACHED() instead of DLOG (I think it's fine
to assume in non-DCHECK builds that we're getting sane data from the server)

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:156: auto key = *it;
const&

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:159: return
std::map<std::string, std::string>();
NOTREACHED()

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:160: auto value = *it;
const&

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.h (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.h:44: base::StringPiece
key_prefix,
Since this is in task_scheduler/, can't it just always use "BrowserScheduler"
internally and not have it as a parameter?

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util_unittest.cc (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util_unittest.cc:211: }
I wouldn't bother testing all invalid inputs. I think it's fine to assume valid
input (i.e. use NOTREACHED() to document it's impossible to get there with
expected input and don't test it).

I think we should test:

1) Mapping variations with no BrowserScheduler* results in no-op.

2) Mapping variations with BrowserScheduler* WAI.

[fdoray, 2016-12-12 18:38:26]

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:129: if
(ContainsSeparator(key_value.first) ||
On 2016/12/12 17:33:33, gab wrote:
> Wrap in #if DCHECK_IS_ON() and NOTREACHED() instead of DLOG (I think it's fine
> to assume in non-DCHECK builds that we're getting sane data from the server)

Are you sure? "Things like disk corruption or strange network errors are
examples of exceptional circumstances that nevertheless should not result in
DCHECK() failure."
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

If so, should we also stop handling errors in
https://cs.chromium.org/chromium/src/components/task_scheduler_util/variation...
?

[gab, 2016-12-13 20:00:00]

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:129: if
(ContainsSeparator(key_value.first) ||
On 2016/12/12 18:38:26, fdoray wrote:
> On 2016/12/12 17:33:33, gab wrote:
> > Wrap in #if DCHECK_IS_ON() and NOTREACHED() instead of DLOG (I think it's
fine
> > to assume in non-DCHECK builds that we're getting sane data from the server)
> 
> Are you sure? "Things like disk corruption or strange network errors are
> examples of exceptional circumstances that nevertheless should not result in
> DCHECK() failure."
>
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

But here, you're doing the encoding, right? It's not from disk or network? If
the config from network is borked, it's up to Finch to verify this, not us,
right?

> 
> If so, should we also stop handling errors in
>
https://cs.chromium.org/chromium/src/components/task_scheduler_util/variation...
> ?

[robliao, 2017-01-03 08:00:01]

lgtm + comments.

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:129: if
(ContainsSeparator(key_value.first) ||
On 2016/12/13 20:00:00, gab (HOHOHO) wrote:
> On 2016/12/12 18:38:26, fdoray wrote:
> > On 2016/12/12 17:33:33, gab wrote:
> > > Wrap in #if DCHECK_IS_ON() and NOTREACHED() instead of DLOG (I think it's
> fine
> > > to assume in non-DCHECK builds that we're getting sane data from the
server)
> > 
> > Are you sure? "Things like disk corruption or strange network errors are
> > examples of exceptional circumstances that nevertheless should not result in
> > DCHECK() failure."
> >
>
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
> 
> But here, you're doing the encoding, right? It's not from disk or network? If
> the config from network is borked, it's up to Finch to verify this, not us,
> right?
> 
> > 
> > If so, should we also stop handling errors in
> >
>
https://cs.chromium.org/chromium/src/components/task_scheduler_util/variation...
> > ?
> 

While we're doing the encoding, we should still be robust to misconfiguration.
If we misconfigure finch (or worse, someone uses a finch based attack vector),
we should immediately reject the config.

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:159: return
std::map<std::string, std::string>();
On 2016/12/12 17:33:33, gab (HOHOHO) wrote:
> NOTREACHED()

Command Lines aren't necessarily a safe data stream, so validating the input
here is appropriate.

https://codereview.chromium.org/2568793003/diff/80001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.h (right):

https://codereview.chromium.org/2568793003/diff/80001/components/task_schedul...
components/task_scheduler_util/common/variations_util.h:39: // Adds key-value
pairs from |variation_params| whose key start with
Nit: Serializes key-value pairs from |variations_params| from keys starting with
|key_prefix| ...

https://codereview.chromium.org/2568793003/diff/80001/components/task_schedul...
components/task_scheduler_util/common/variations_util.h:47: // Returns a map
with key-value pairs read from the
Nit: Returns a map of key-value pairs deserialized from the...

https://codereview.chromium.org/2568793003/diff/80001/components/task_schedul...
File components/task_scheduler_util/renderer/BUILD.gn (right):

https://codereview.chromium.org/2568793003/diff/80001/components/task_schedul...
components/task_scheduler_util/renderer/BUILD.gn:1: # Copyright 2016 The
Chromium Authors. All rights reserved.
I guess it's time to change these to 2017. Happy New Year!

[fdoray, 2017-01-04 22:47:32]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-01-04 22:47:39]

PTAnL

https://codereview.chromium.org/2568793003/diff/80001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.h (right):

https://codereview.chromium.org/2568793003/diff/80001/components/task_schedul...
components/task_scheduler_util/common/variations_util.h:39: // Adds key-value
pairs from |variation_params| whose key start with
On 2017/01/03 08:00:01, robliao - PST plus 16h wrote:
> Nit: Serializes key-value pairs from |variations_params| from keys starting
with
> |key_prefix| ...

Done.

https://codereview.chromium.org/2568793003/diff/80001/components/task_schedul...
components/task_scheduler_util/common/variations_util.h:47: // Returns a map
with key-value pairs read from the
On 2017/01/03 08:00:01, robliao - PST plus 16h wrote:
> Nit: Returns a map of key-value pairs deserialized from the...

Done.

https://codereview.chromium.org/2568793003/diff/80001/components/task_schedul...
File components/task_scheduler_util/renderer/BUILD.gn (right):

https://codereview.chromium.org/2568793003/diff/80001/components/task_schedul...
components/task_scheduler_util/renderer/BUILD.gn:1: # Copyright 2016 The
Chromium Authors. All rights reserved.
On 2017/01/03 08:00:01, robliao - PST plus 16h wrote:
> I guess it's time to change these to 2017. Happy New Year!

Done.

[commit-bot: I haz the power, 2017-01-04 22:48:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 00:34:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 00:34:58]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[robliao, 2017-01-05 08:09:21]

SLGTM

[fdoray, 2017-01-05 16:33:15]

fdoray@chromium.org changed reviewers:
+ sky@chromium.org

[fdoray, 2017-01-05 16:33:15]

sky@: Please review changes in chrome/renderer/

[sky, 2017-01-05 17:28:57]

LGTM

[fdoray, 2017-01-05 18:36:11]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-01-05 18:36:11]

The patchset sent to the CQ was uploaded after l-g-t-m from robliao@chromium.org
Link to the patchset: https://codereview.chromium.org/2568793003/#ps100001
(title: "CR robliao #6")

[commit-bot: I haz the power, 2017-01-05 18:36:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-01-05 18:40:05]

Seems like my review was missed?

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:156: auto key = *it;
On 2016/12/12 17:33:33, gab wrote:
> const&

ping

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:159: return
std::map<std::string, std::string>();
On 2017/01/03 08:00:01, robliao - PST plus 16h wrote:
> On 2016/12/12 17:33:33, gab (HOHOHO) wrote:
> > NOTREACHED()
> 
> Command Lines aren't necessarily a safe data stream, so validating the input
> here is appropriate.

Sure but there's something seriously wrong if this fails and a developer should
be warned via a NOTREACHED() IMO (I'm okay deviating slightly from the
"NOTREACHED() means cannot be reached ever" here because this is not
typical/expected edge case error handling).

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:160: auto value = *it;
On 2016/12/12 17:33:33, gab wrote:
> const&

ping

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.h (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.h:44: base::StringPiece
key_prefix,
On 2016/12/12 17:33:33, gab wrote:
> Since this is in task_scheduler/, can't it just always use "BrowserScheduler"
> internally and not have it as a parameter?

ping

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util_unittest.cc (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util_unittest.cc:211: }
On 2016/12/12 17:33:33, gab wrote:
> I wouldn't bother testing all invalid inputs. I think it's fine to assume
valid
> input (i.e. use NOTREACHED() to document it's impossible to get there with
> expected input and don't test it).
> 
> I think we should test:
> 
> 1) Mapping variations with no BrowserScheduler* results in no-op.
> 
> 2) Mapping variations with BrowserScheduler* WAI.

ping

[gab, 2017-01-05 18:40:15]

The CQ bit was unchecked by gab@chromium.org

[fdoray, 2017-01-06 17:23:52]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 17:24:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-01-06 17:29:04]

gab@: PTAnL

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:156: auto key = *it;
On 2017/01/05 18:40:05, gab wrote:
> On 2016/12/12 17:33:33, gab wrote:
> > const&
> 
> ping

This is a StringPiece. Changed auto -> StringPiece to be more explicit.

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:159: return
std::map<std::string, std::string>();
On 2017/01/05 18:40:05, gab wrote:
> On 2017/01/03 08:00:01, robliao - PST plus 16h wrote:
> > On 2016/12/12 17:33:33, gab (HOHOHO) wrote:
> > > NOTREACHED()
> > 
> > Command Lines aren't necessarily a safe data stream, so validating the input
> > here is appropriate.
> 
> Sure but there's something seriously wrong if this fails and a developer
should
> be warned via a NOTREACHED() IMO (I'm okay deviating slightly from the
> "NOTREACHED() means cannot be reached ever" here because this is not
> typical/expected edge case error handling).

Done.

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.cc:160: auto value = *it;
On 2017/01/05 18:40:05, gab wrote:
> On 2016/12/12 17:33:33, gab wrote:
> > const&
> 
> ping

This is a StringPiece. Changed auto -> StringPiece to be more explicit.

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util.h (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util.h:44: base::StringPiece
key_prefix,
On 2017/01/05 18:40:05, gab wrote:
> On 2016/12/12 17:33:33, gab wrote:
> > Since this is in task_scheduler/, can't it just always use
"BrowserScheduler"
> > internally and not have it as a parameter?
> 
> ping

|prefix| determines which variation params are added to a child process command
line. For renderers, we use "Renderer"
https://codereview.chromium.org/2568793003/diff/80001/chrome/browser/chrome_c...
We never use "BrowserScheduler".

I removed the |variation_params| argument and replaced it with an internal call
to variations::GetVariationParams("BrowserScheduler", ...);

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
File components/task_scheduler_util/common/variations_util_unittest.cc (right):

https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...
components/task_scheduler_util/common/variations_util_unittest.cc:211: }
On 2017/01/05 18:40:05, gab wrote:
> On 2016/12/12 17:33:33, gab wrote:
> > I wouldn't bother testing all invalid inputs. I think it's fine to assume
> valid
> > input (i.e. use NOTREACHED() to document it's impossible to get there with
> > expected input and don't test it).
> > 
> > I think we should test:
> > 
> > 1) Mapping variations with no BrowserScheduler* results in no-op.
> > 
> > 2) Mapping variations with BrowserScheduler* WAI.
> 
> ping

~ done. I think you didn't correctly understand the purpose of the |prefix|. See
https://codereview.chromium.org/2568793003/diff/20001/components/task_schedul...

[fdoray, 2017-01-06 17:31:12]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 17:31:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-01-06 17:41:09]

lgtm w/ comments

Also, this makes me think that we might want to split this from the
BrowserScheduler experiment? Otherwise we'll end up with many unrelated groups
in the same experiment and each group's population will be ridiculously tiny...
(unless we believe there will be experiments that require tweaks on both
browser/renderer sides? in which case BrowserScheduler is no longer a good
name..!)... anyways doesn't need to block this but food for thought...

https://codereview.chromium.org/2568793003/diff/140001/components/task_schedu...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2568793003/diff/140001/components/task_schedu...
components/task_scheduler_util/common/variations_util.cc:161: DCHECK(it !=
parts.end());
Rob had a good point that we still need to handle an incorrect command-line but
I'd still like to see a NOTREACHED() in the if{} because although it can
theoretically happen it'd 99.9999999% of the time be a sign of a real bug IMO.

https://codereview.chromium.org/2568793003/diff/140001/components/task_schedu...
File components/task_scheduler_util/common/variations_util_unittest.cc (right):

https://codereview.chromium.org/2568793003/diff/140001/components/task_schedu...
components/task_scheduler_util/common/variations_util_unittest.cc:56:
base::FieldTrialList field_trial_list_;
= nullptr; (and make constructor = default;)

[commit-bot: I haz the power, 2017-01-06 17:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 17:58:35]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[fdoray, 2017-01-06 18:10:39]

https://codereview.chromium.org/2568793003/diff/140001/components/task_schedu...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2568793003/diff/140001/components/task_schedu...
components/task_scheduler_util/common/variations_util.cc:161: DCHECK(it !=
parts.end());
On 2017/01/06 17:41:09, gab wrote:
> Rob had a good point that we still need to handle an incorrect command-line
but
> I'd still like to see a NOTREACHED() in the if{} because although it can
> theoretically happen it'd 99.9999999% of the time be a sign of a real bug IMO.

Done.

https://codereview.chromium.org/2568793003/diff/140001/components/task_schedu...
File components/task_scheduler_util/common/variations_util_unittest.cc (right):

https://codereview.chromium.org/2568793003/diff/140001/components/task_schedu...
components/task_scheduler_util/common/variations_util_unittest.cc:56:
base::FieldTrialList field_trial_list_;
On 2017/01/06 17:41:09, gab wrote:
> = nullptr; (and make constructor = default;)

Doesn't work. nullptr is an argument for the constructor of
base::FieldTrialList, not a value to be assigned to |field_trial_list_|. =
base::FieldTrialList(nullptr) doesn't work either because the assignment
operator does not exist.

[fdoray, 2017-01-06 18:10:45]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-01-06 18:10:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
robliao@chromium.org, sky@chromium.org, gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2568793003/#ps160001
(title: "CR gab #26 (handle invalid cmd line)")

[commit-bot: I haz the power, 2017-01-06 18:11:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 18:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 18:20:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[fdoray, 2017-01-06 18:36:03]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 18:36:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-01-06 18:36:57]

fdoray@chromium.org changed reviewers:
+ rkaplow@chromium.org

[fdoray, 2017-01-06 18:36:58]

rkaplow@: Please review chrome/renderer/DEPS (added dependency on
components/variations)

[gab, 2017-01-06 18:48:40]

https://codereview.chromium.org/2568793003/diff/180001/components/task_schedu...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2568793003/diff/180001/components/task_schedu...
components/task_scheduler_util/common/variations_util.cc:173: #endif //
!defined(OS_IOS)
style nit: two spaces before //

(and elsewhere)

[commit-bot: I haz the power, 2017-01-06 19:04:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 19:04:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[rkaplow, 2017-01-06 19:13:24]

lgtm

[fdoray, 2017-01-06 22:26:49]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-01-06 22:26:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
robliao@chromium.org, gab@chromium.org, sky@chromium.org, rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2568793003/#ps200001
(title: "set field trial group in tests")

[commit-bot: I haz the power, 2017-01-06 22:27:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 22:34:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 22:34:15]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[fdoray, 2017-01-06 22:48:53]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-01-06 22:48:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
robliao@chromium.org, gab@chromium.org, rkaplow@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2568793003/#ps220001
(title: "fix ios build error")

[commit-bot: I haz the power, 2017-01-06 22:49:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 22:56:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 22:56:20]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[fdoray, 2017-01-06 22:57:25]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-01-06 22:57:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
robliao@chromium.org, gab@chromium.org, rkaplow@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2568793003/#ps240001
(title: "fix ios build error")

[commit-bot: I haz the power, 2017-01-06 22:57:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 00:30:33]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1483743445393030,
"parent_rev": "91f5b8d2f34faf9c21fb4c08146cb1a7d9ad2144", "commit_rev":
"1e3963fb07388dd5175f9e2d7bcd7ee1e3c8f134"}

[commit-bot: I haz the power, 2017-01-07 00:31:01]

Description was changed from

==========
Control TaskScheduler initialization params in renderers via field trial.

BUG=664996
==========

to

==========
Control TaskScheduler initialization params in renderers via field trial.

BUG=664996

Review-Url: https://codereview.chromium.org/2568793003
Cr-Commit-Position: refs/heads/master@{#442109}
Committed:
https://chromium.googlesource.com/chromium/src/+/1e3963fb07388dd5175f9e2d7bcd...
==========

[commit-bot: I haz the power, 2017-01-07 00:31:02]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/1e3963fb07388dd5175f9e2d7bcd...