Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2568783002: [mus] Use external BeginFrameSource in browser client. (Closed)

Created:
4 years ago by Eric Seckler
Modified:
4 years ago
Reviewers:
Fady Samuel, jbauman
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, Sami, brianderson, enne (OOO), danakj, sunnyps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mus] Use external BeginFrameSource in browser client. This plugs the ExternalBeginFrameSource provided by WindowCompositorFrameSink into the browser's cc::Display, effectively enabling unified BeginFrames for the browser client. BUG=580357 Committed: https://crrev.com/f0e7cb9bd7bfa56a219e31fed32775cddfd58f7a Cr-Commit-Position: refs/heads/master@{#438495}

Patch Set 1 : . #

Patch Set 2 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.cc View 1 4 chunks +15 lines, -7 lines 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 1 4 chunks +11 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (20 generated)
Eric Seckler
Fady, PTAL :) John, also adding you for: content/browser/compositor/gpu_process_transport_factory.cc Thanks!
4 years ago (2016-12-12 16:12:44 UTC) #16
Fady Samuel
lgtm
4 years ago (2016-12-12 16:14:51 UTC) #17
Eric Seckler
cc-ing relevant folks.
4 years ago (2016-12-12 16:24:04 UTC) #18
jbauman
lgtm
4 years ago (2016-12-13 00:34:35 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568783002/60001
4 years ago (2016-12-14 12:12:59 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years ago (2016-12-14 13:05:25 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-14 13:07:42 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0e7cb9bd7bfa56a219e31fed32775cddfd58f7a
Cr-Commit-Position: refs/heads/master@{#438495}

Powered by Google App Engine
This is Rietveld 408576698