Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2568773002: [wasm][asm.js] Forbid function declaration replacing variable declaration. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
titzer, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Forbid function declaration replacing variable declaration. BUG=673240 R=titzer@chromium.org Committed: https://crrev.com/7659728be281f9adb76edf3b0e4a9800f24ebc4a Cr-Commit-Position: refs/heads/master@{#41638}

Patch Set 1 #

Patch Set 2 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M src/asmjs/asm-typer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 1 2 chunks +10 lines, -12 lines 0 comments Download
M test/mjsunit/asm/asm-validation.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
bradn
PTAL
4 years ago (2016-12-12 08:30:38 UTC) #4
titzer
On 2016/12/12 08:30:38, bradn wrote: > PTAL lgtm
4 years ago (2016-12-12 12:11:02 UTC) #11
titzer
On 2016/12/12 08:30:38, bradn wrote: > PTAL lgtm
4 years ago (2016-12-12 12:11:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568773002/20001
4 years ago (2016-12-12 12:23:37 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 12:26:08 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-12 12:27:21 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7659728be281f9adb76edf3b0e4a9800f24ebc4a
Cr-Commit-Position: refs/heads/master@{#41638}

Powered by Google App Engine
This is Rietveld 408576698