Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2568743009: Fix low risk trivial non-nullable =>nullable idl mismatch in WebGL2RenderingContextBase.idl (Closed)

Created:
4 years ago by lunalu1
Modified:
4 years ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix low risk trivial non-nullable => nullable idl mismatch in WebGL2RenderingContextBase.idl https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7 create*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6ea094398a321f2d36aa82fd52087f40d64df651 Cr-Commit-Position: refs/heads/master@{#438601}

Patch Set 1 #

Patch Set 2 : Revert change made to readPixels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
lunalu1
4 years ago (2016-12-14 13:59:56 UTC) #3
foolip
lgtm
4 years ago (2016-12-14 14:34:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568743009/20001
4 years ago (2016-12-14 14:34:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/199004)
4 years ago (2016-12-14 14:47:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568743009/20001
4 years ago (2016-12-14 15:56:02 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 19:54:12 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-14 19:55:45 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ea094398a321f2d36aa82fd52087f40d64df651
Cr-Commit-Position: refs/heads/master@{#438601}

Powered by Google App Engine
This is Rietveld 408576698