|
|
Chromium Code Reviews
DescriptionFix low risk trivial non-nullable => nullable idl mismatch in WebGL2RenderingContextBase.idl
https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7
create*() methods, fenceSync() method, and getTransformFeedbackVarying()
method cause no change in generated files
BUG=662005
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/6ea094398a321f2d36aa82fd52087f40d64df651
Cr-Commit-Position: refs/heads/master@{#438601}
Patch Set 1 #Patch Set 2 : Revert change made to readPixels #Messages
Total messages: 22 (15 generated)
Description was changed from ========== Fix low risk trivial non-nullable =>nullable idl mismatch in WebGL2RenderingContextBase.idl creat*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files. readPixels() does modify a conditional statement, but seems low risk. BUG=662005 ========== to ========== Fix low risk trivial non-nullable =>nullable idl mismatch in WebGL2RenderingContextBase.idl creat*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files. readPixels() does modify a conditional statement, but seems low risk. BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
lunalu@chromium.org changed reviewers: + foolip@chromium.org
Description was changed from ========== Fix low risk trivial non-nullable =>nullable idl mismatch in WebGL2RenderingContextBase.idl creat*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files. readPixels() does modify a conditional statement, but seems low risk. BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix low risk trivial non-nullable =>nullable idl mismatch in WebGL2RenderingContextBase.idl creat*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix low risk trivial non-nullable =>nullable idl mismatch in WebGL2RenderingContextBase.idl creat*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix low risk trivial non-nullable =>nullable idl mismatch in WebGL2RenderingContextBase.idl create*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Fix low risk trivial non-nullable =>nullable idl mismatch in WebGL2RenderingContextBase.idl create*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix low risk trivial non-nullable => nullable idl mismatch in WebGL2RenderingContextBase.idl https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7 create*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
lgtm
The CQ bit was unchecked by foolip@chromium.org
The CQ bit was checked by foolip@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
The CQ bit was checked by lunalu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481730947641970,
"parent_rev": "2fa489c26b53d35cce789dda5c1ffdb94bb09e0c", "commit_rev":
"8e2866f36afa22be95f3a740d8d474b0dde607fb"}
Message was sent while issue was closed.
Description was changed from ========== Fix low risk trivial non-nullable => nullable idl mismatch in WebGL2RenderingContextBase.idl https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7 create*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix low risk trivial non-nullable => nullable idl mismatch in WebGL2RenderingContextBase.idl https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7 create*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2568743009 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix low risk trivial non-nullable => nullable idl mismatch in WebGL2RenderingContextBase.idl https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7 create*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2568743009 ========== to ========== Fix low risk trivial non-nullable => nullable idl mismatch in WebGL2RenderingContextBase.idl https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7 create*() methods, fenceSync() method, and getTransformFeedbackVarying() method cause no change in generated files BUG=662005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6ea094398a321f2d36aa82fd52087f40d64df651 Cr-Commit-Position: refs/heads/master@{#438601} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6ea094398a321f2d36aa82fd52087f40d64df651 Cr-Commit-Position: refs/heads/master@{#438601} |
