Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2568723006: Remove blink::Stream related code from FileReaderLoader (Closed)

Created:
4 years ago by yhirano
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove blink::Stream related code from FileReaderLoader No one is using the code any more. BUG=None R=tyoshino@chromium.org Committed: https://crrev.com/199daadb512fd39c2c8c3e56f536acb7eb941fb4 Cr-Commit-Position: refs/heads/master@{#438707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -50 lines) Patch
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.h View 4 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp View 4 chunks +11 lines, -44 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
yhirano
4 years ago (2016-12-14 01:31:11 UTC) #5
tyoshino (SeeGerritForStatus)
lgtm
4 years ago (2016-12-14 07:08:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568723006/1
4 years ago (2016-12-14 07:57:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/325665)
4 years ago (2016-12-14 08:04:41 UTC) #10
yhirano
+kouhei@
4 years ago (2016-12-14 13:36:31 UTC) #13
kouhei (in TOK)
lgtm rs
4 years ago (2016-12-14 22:46:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568723006/1
4 years ago (2016-12-14 22:47:46 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 01:33:41 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-15 01:35:57 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/199daadb512fd39c2c8c3e56f536acb7eb941fb4
Cr-Commit-Position: refs/heads/master@{#438707}

Powered by Google App Engine
This is Rietveld 408576698