Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2568723005: Add scan mode to choose whether to do content scan or only history check. (Closed)

Created:
4 years ago by yamaguchi
Modified:
4 years ago
Reviewers:
fukino
CC:
chromium-reviews, tfarina, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add scan mode parameter to choose whether to do content duplication check or just check the import history. This change will not actually change the behavior of the app but will be used by a following change https://codereview.chromium.org/2569163002/ . BUG=668574 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4703c1fc80d263275181e92c9bd1e124036f4e64 Cr-Commit-Position: refs/heads/master@{#439422}

Patch Set 1 #

Patch Set 2 : Add some jsdoc comment. #

Total comments: 2

Patch Set 3 : Remove unrelated changes that was put in by mistake. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -36 lines) Patch
M ui/file_manager/file_manager/background/js/duplicate_finder.js View 3 chunks +22 lines, -16 lines 0 comments Download
M ui/file_manager/file_manager/background/js/media_scanner.js View 1 9 chunks +23 lines, -9 lines 0 comments Download
M ui/file_manager/file_manager/common/js/importer_common.js View 1 1 chunk +13 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 2 6 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
fukino
Sorry for a late response. https://codereview.chromium.org/2568723005/diff/20001/ui/file_manager/file_manager/foreground/js/import_controller.js File ui/file_manager/file_manager/foreground/js/import_controller.js (right): https://codereview.chromium.org/2568723005/diff/20001/ui/file_manager/file_manager/foreground/js/import_controller.js#newcode295 ui/file_manager/file_manager/foreground/js/import_controller.js:295: var scan = this.scanManager_.getActiveScan(); ...
4 years ago (2016-12-16 05:07:41 UTC) #11
yamaguchi
https://codereview.chromium.org/2568723005/diff/20001/ui/file_manager/file_manager/foreground/js/import_controller.js File ui/file_manager/file_manager/foreground/js/import_controller.js (right): https://codereview.chromium.org/2568723005/diff/20001/ui/file_manager/file_manager/foreground/js/import_controller.js#newcode295 ui/file_manager/file_manager/foreground/js/import_controller.js:295: var scan = this.scanManager_.getActiveScan(); On 2016/12/16 05:07:41, fukino wrote: ...
4 years ago (2016-12-16 06:52:37 UTC) #12
fukino
lgtm
4 years ago (2016-12-19 06:24:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568723005/40001
4 years ago (2016-12-19 06:41:26 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-19 07:06:22 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-19 07:08:26 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4703c1fc80d263275181e92c9bd1e124036f4e64
Cr-Commit-Position: refs/heads/master@{#439422}

Powered by Google App Engine
This is Rietveld 408576698