Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2568723003:
[deoptimizer] Enable test that should no longer fail. (Closed)
|
Created:
4 years ago by Michael Starzinger Modified:
4 years ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[deoptimizer] Enable test that should no longer fail.
R=jarin@chromium.org
TEST=cctest/test-cpu-profiler/CollectDeoptEvents
Committed: https://crrev.com/3f9c2c590d687562d6adb531d1159738c07013f4
Cr-Commit-Position: refs/heads/master@{#41664}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Follow-up to https://codereview.chromium.org/2565733002/, which hopefully fixes the test in question on all architectures. Lets see what the try-jobs and the waterfall have to say.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
lgtm
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481620613019520, "parent_rev":
"2e30434295e804c049832309c70935db94a77009", "commit_rev":
"9b0f4c93ca39d0baf2019980a41b3cc281654436"}
Message was sent while issue was closed.
Description was changed from ========== [deoptimizer] Enable test that should no longer fail. R=jarin@chromium.org TEST=cctest/test-cpu-profiler/CollectDeoptEvents ========== to ========== [deoptimizer] Enable test that should no longer fail. R=jarin@chromium.org TEST=cctest/test-cpu-profiler/CollectDeoptEvents Review-Url: https://codereview.chromium.org/2568723003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [deoptimizer] Enable test that should no longer fail. R=jarin@chromium.org TEST=cctest/test-cpu-profiler/CollectDeoptEvents Review-Url: https://codereview.chromium.org/2568723003 ========== to ========== [deoptimizer] Enable test that should no longer fail. R=jarin@chromium.org TEST=cctest/test-cpu-profiler/CollectDeoptEvents Committed: https://crrev.com/3f9c2c590d687562d6adb531d1159738c07013f4 Cr-Commit-Position: refs/heads/master@{#41664} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3f9c2c590d687562d6adb531d1159738c07013f4 Cr-Commit-Position: refs/heads/master@{#41664}
Message was sent while issue was closed.
On 2016/12/13 09:19:46, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/3f9c2c590d687562d6adb531d1159738c07013f4 > Cr-Commit-Position: refs/heads/master@{#41664} https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2568403003/ by mstarzinger@chromium.org. The reason for reverting is: Still flakes on ARM.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
