 Chromium Code Reviews
 Chromium Code Reviews Issue 2568713002:
  [stubs] Fixing issues found by machine graph verifier in code stubs.  (Closed)
    
  
    Issue 2568713002:
  [stubs] Fixing issues found by machine graph verifier in code stubs.  (Closed) 
  | Index: src/code-stubs.cc | 
| diff --git a/src/code-stubs.cc b/src/code-stubs.cc | 
| index c97ba3db2d59ed3458505b1f359f3e8432db8a34..4456b4df6884e068f4085bf2ae6204765c3e36db 100644 | 
| --- a/src/code-stubs.cc | 
| +++ b/src/code-stubs.cc | 
| @@ -437,7 +437,15 @@ Handle<Code> TurboFanCodeStub::GenerateCode() { | 
| compiler::CodeAssemblerState state(isolate(), &zone, descriptor, | 
| GetCodeFlags(), name); | 
| GenerateAssembly(&state); | 
| - return compiler::CodeAssembler::GenerateCode(&state); | 
| + | 
| + // TODO(ishell): remove this when code stub assembler graphs verification | 
| + // is enabled for all stubs. | 
| + bool sav_csa_verify = FLAG_csa_verify; | 
| 
Camillo Bruni
2016/12/12 15:17:37
nit: saved_csa_verify
 
Igor Sheludko
2016/12/12 15:25:12
Done.
 | 
| + // Enable verification only in mksnapshot. | 
| + FLAG_csa_verify = DEBUG_BOOL && FLAG_startup_blob != nullptr; | 
| + Handle<Code> code = compiler::CodeAssembler::GenerateCode(&state); | 
| + FLAG_csa_verify = sav_csa_verify; | 
| + return code; | 
| } | 
| #define ACCESSOR_ASSEMBLER(Name) \ |