 Chromium Code Reviews
 Chromium Code Reviews Issue 2568713002:
  [stubs] Fixing issues found by machine graph verifier in code stubs.  (Closed)
    
  
    Issue 2568713002:
  [stubs] Fixing issues found by machine graph verifier in code stubs.  (Closed) 
  | Index: src/builtins/builtins.cc | 
| diff --git a/src/builtins/builtins.cc b/src/builtins/builtins.cc | 
| index 5997eb35506054e084c3a8394ea5f79b70aa8852..45f2fa07029b1ddae8c1483a0a6691c5c50e5cdf 100644 | 
| --- a/src/builtins/builtins.cc | 
| +++ b/src/builtins/builtins.cc | 
| @@ -108,7 +108,14 @@ Code* BuildWithCodeStubAssemblerCS(Isolate* isolate, | 
| DCHECK_LE(0, descriptor.GetRegisterParameterCount()); | 
| compiler::CodeAssemblerState state(isolate, &zone, descriptor, flags, name); | 
| generator(&state); | 
| + | 
| + // TODO(ishell): remove this when code stub assembler graphs verification | 
| + // is enabled for all stubs. | 
| + bool sav_csa_verify = FLAG_csa_verify; | 
| 
Camillo Bruni
2016/12/12 15:17:37
nit: saved_csa_verify ?
 
Igor Sheludko
2016/12/12 15:25:12
Done.
 | 
| + // Enable verification only in mksnapshot. | 
| + FLAG_csa_verify = DEBUG_BOOL && FLAG_startup_blob != nullptr; | 
| Handle<Code> code = compiler::CodeAssembler::GenerateCode(&state); | 
| + FLAG_csa_verify = sav_csa_verify; | 
| PostBuildProfileAndTracing(isolate, *code, name); | 
| return *code; | 
| } |