Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2568703003: Update comment about SIGINT on Windows in Executive. (Closed)

Created:
4 years ago by qyearsley
Modified:
4 years ago
Reviewers:
Dirk Pranke, jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update comment about SIGINT on Windows in Executive. I tried this out by running an instance of python.exe in one cmd window, and tried interrupting it elsewhere with os.kill(pid, signal.CTRL_C_EVENT), which didn't work, but os.kill(pid, signal.SIGINT) did end the process. Committed: https://crrev.com/ebfb064268917e3104f3e8f36277ab5e260f691e Cr-Commit-Position: refs/heads/master@{#438666}

Patch Set 1 #

Patch Set 2 : Update comment about SIGINT on Windows in Executive. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
qyearsley
4 years ago (2016-12-14 19:47:21 UTC) #3
jeffcarp
lgtm
4 years ago (2016-12-14 20:05:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568703003/20001
4 years ago (2016-12-14 22:10:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 23:16:24 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-14 23:19:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebfb064268917e3104f3e8f36277ab5e260f691e
Cr-Commit-Position: refs/heads/master@{#438666}

Powered by Google App Engine
This is Rietveld 408576698