Re-land "Detect floats to avoid or clear due to negative margin top (and followup)"

Re-land "Detect floats to avoid or clear due to negative margin top (and followup)"

Re-land https://codereview.chromium.org/2531953002 and
https://codereview.chromium.org/2547933003.

When a negative margin top pushes a block back up into its previous siblings
we need to check for any floats in those siblings it now needs to avoid or clear.

Previously we were just looking at its neighbour, we need to keep looking until
we reach a sibling that we don't overlap.

Fix the performance regression on mossiella.com in page_cycler_v2.tough_layout_cases
by only looking for floats if margin collapsing has actually moved the child up.

BUG=671645, 670325, 666487
Committed: https://crrev.com/5c6452a360ed086b96680a2cad532e2be7d68385
Cr-Commit-Position: refs/heads/master@{#437951}

[rhogan, 2016-12-10 13:07:08]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 13:07:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2016-12-10 13:13:01]

Description was changed from

==========
Re-land "Detect floats to avoid or clear due to negative margin top (and
followup)"

BUG=671645, 670325, 666487
==========

to

==========
Re-land "Detect floats to avoid or clear due to negative margin top (and
followup)"

Fix the performance regression in mo
BUG=671645, 670325, 666487
==========

[rhogan, 2016-12-10 13:14:09]

Description was changed from

==========
Re-land "Detect floats to avoid or clear due to negative margin top (and
followup)"

Fix the performance regression in mo
BUG=671645, 670325, 666487
==========

to

==========
Re-land "Detect floats to avoid or clear due to negative margin top (and
followup)"

Fix the performance regression on mossiella.com in
page_cycler_v2.tough_layout_cases
by only looking for floats if margin collapsing has actually moved the child up.

BUG=671645, 670325, 666487
==========

[rhogan, 2016-12-10 13:14:25]

robhogan@gmail.com changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2016-12-10 14:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 14:28:31]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-12-12 18:30:49]

On 2016/12/10 at 13:14:26, robhogan wrote:
> 

LGTM

Can you please update the change description to include the full context of this
change? It'll make future code archaeology a little easier. Just add this to the
change description:
"""
When a negative margin top pushes a block back up into its previous siblings
we need to check for any floats in those siblings it now needs to avoid or
clear.

Previously we were just looking at its neighbour, we need to keep looking until
we reach a sibling that we don't overlap.
"""

[rhogan, 2016-12-12 19:13:45]

Description was changed from

==========
Re-land "Detect floats to avoid or clear due to negative margin top (and
followup)"

Fix the performance regression on mossiella.com in
page_cycler_v2.tough_layout_cases
by only looking for floats if margin collapsing has actually moved the child up.

BUG=671645, 670325, 666487
==========

to

==========
Re-land "Detect floats to avoid or clear due to negative margin top (and
followup)"

Re-land https://codereview.chromium.org/2531953002 and
https://codereview.chromium.org/2547933003.

When a negative margin top pushes a block back up into its previous siblings
we need to check for any floats in those siblings it now needs to avoid or
clear.

Previously we were just looking at its neighbour, we need to keep looking until
we reach a sibling that we don't overlap.

Fix the performance regression on mossiella.com in
page_cycler_v2.tough_layout_cases
by only looking for floats if margin collapsing has actually moved the child up.

BUG=671645, 670325, 666487
==========

[rhogan, 2016-12-12 19:13:50]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-12-12 19:14:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 23:20:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481570030680700, "parent_rev":
"99300aa8adaf8148be5499c286caa322d0681a7f", "commit_rev":
"6a2ce6beaa707d3f59280ae552e323a76e225f86"}

[commit-bot: I haz the power, 2016-12-12 23:20:50]

Description was changed from

==========
Re-land "Detect floats to avoid or clear due to negative margin top (and
followup)"

Re-land https://codereview.chromium.org/2531953002 and
https://codereview.chromium.org/2547933003.

When a negative margin top pushes a block back up into its previous siblings
we need to check for any floats in those siblings it now needs to avoid or
clear.

Previously we were just looking at its neighbour, we need to keep looking until
we reach a sibling that we don't overlap.

Fix the performance regression on mossiella.com in
page_cycler_v2.tough_layout_cases
by only looking for floats if margin collapsing has actually moved the child up.

BUG=671645, 670325, 666487
==========

to

==========
Re-land "Detect floats to avoid or clear due to negative margin top (and
followup)"

Re-land https://codereview.chromium.org/2531953002 and
https://codereview.chromium.org/2547933003.

When a negative margin top pushes a block back up into its previous siblings
we need to check for any floats in those siblings it now needs to avoid or
clear.

Previously we were just looking at its neighbour, we need to keep looking until
we reach a sibling that we don't overlap.

Fix the performance regression on mossiella.com in
page_cycler_v2.tough_layout_cases
by only looking for floats if margin collapsing has actually moved the child up.

BUG=671645, 670325, 666487

Review-Url: https://codereview.chromium.org/2568643002
==========

[commit-bot: I haz the power, 2016-12-12 23:20:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 23:23:18]

Description was changed from

==========
Re-land "Detect floats to avoid or clear due to negative margin top (and
followup)"

Re-land https://codereview.chromium.org/2531953002 and
https://codereview.chromium.org/2547933003.

When a negative margin top pushes a block back up into its previous siblings
we need to check for any floats in those siblings it now needs to avoid or
clear.

Previously we were just looking at its neighbour, we need to keep looking until
we reach a sibling that we don't overlap.

Fix the performance regression on mossiella.com in
page_cycler_v2.tough_layout_cases
by only looking for floats if margin collapsing has actually moved the child up.

BUG=671645, 670325, 666487

Review-Url: https://codereview.chromium.org/2568643002
==========

to

==========
Re-land "Detect floats to avoid or clear due to negative margin top (and
followup)"

Re-land https://codereview.chromium.org/2531953002 and
https://codereview.chromium.org/2547933003.

When a negative margin top pushes a block back up into its previous siblings
we need to check for any floats in those siblings it now needs to avoid or
clear.

Previously we were just looking at its neighbour, we need to keep looking until
we reach a sibling that we don't overlap.

Fix the performance regression on mossiella.com in
page_cycler_v2.tough_layout_cases
by only looking for floats if margin collapsing has actually moved the child up.

BUG=671645, 670325, 666487

Committed: https://crrev.com/5c6452a360ed086b96680a2cad532e2be7d68385
Cr-Commit-Position: refs/heads/master@{#437951}
==========

[commit-bot: I haz the power, 2016-12-12 23:23:19]

Patchset 1 (id:??) landed as
https://crrev.com/5c6452a360ed086b96680a2cad532e2be7d68385
Cr-Commit-Position: refs/heads/master@{#437951}