MD Settings: Internet: Only show detailed info for primary user.

MD Settings: Internet: Only show detailed info for primary user.

BUG=648498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/bfeca7cd9b6e45c1e00cb86dd44eac76f2e082b9
Cr-Commit-Position: refs/heads/master@{#438379}

[stevenjb, 2016-12-09 23:28:23]

Description was changed from

==========
MD Settings: Internet: Only show detailed info for primary user.


MD Settings: About: Fixes to channel switcher dialog

BUG=648498
==========

to

==========
MD Settings: Internet: Only show detailed info for primary user.


MD Settings: About: Fixes to channel switcher dialog

BUG=648498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-12-09 23:29:37]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2016-12-12 20:59:29]

not sure what happened here, merged a couple CLs?

[stevenjb, 2016-12-12 21:06:10]

On 2016/12/12 20:59:29, michaelpg wrote:
> not sure what happened here, merged a couple CLs?

Sigh. git cl used to be better about default upstream. Rebased, PTAL.

[stevenjb, 2016-12-12 21:10:51]

https://codereview.chromium.org/2568593002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.html
(right):

https://codereview.chromium.org/2568593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.html:156:
<!-- Top level properties -->
Ugh, sorry, coderview diff sucks. Nothing below this point actually changed, I
just triple checked it.

[michaelpg, 2016-12-12 23:17:00]

also update CL description :)

https://codereview.chromium.org/2568593002/diff/20001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2568593002/diff/20001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:1056: <message
name="IDS_SETTINGS_INTERNET_NETWORK_PRIMARY_USER_CONTROLLED" desc="Settings >
Internet > Network details: Text to show when a network configuraiton is
controlled by the primary user.">
configuration

https://codereview.chromium.org/2568593002/diff/20001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:1057: Network configuraiton is controlled by
<ph name="USER_EMAIL">$1<ex>joe@gmail.com</ex></ph>.
same

https://codereview.chromium.org/2568593002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2568593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:244: *
networkingPrivate.getProperties callback.
getState

https://codereview.chromium.org/2568593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:250: //
If |properties| becomes null (i.e. the network is no longer visible),
|state|?

https://codereview.chromium.org/2568593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:312:
return !!this.primaryUserEmail_;
Can we use loadTimeData.getBoolean('isSecondaryUser'), maybe as its own
property? isSecondaryUser_ never changes, so we shouldn't have to set up all the
event listeners and such that Polymer would create for this binding.

Also, primaryUserEmail_ might not be set properly in situations like CrOS on
Linux or tests, maybe.

[stevenjb, 2016-12-12 23:23:23]

Description was changed from

==========
MD Settings: Internet: Only show detailed info for primary user.


MD Settings: About: Fixes to channel switcher dialog

BUG=648498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Only show detailed info for primary user.

BUG=648498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-12-13 00:57:55]

PTAL

https://codereview.chromium.org/2568593002/diff/20001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2568593002/diff/20001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:1056: <message
name="IDS_SETTINGS_INTERNET_NETWORK_PRIMARY_USER_CONTROLLED" desc="Settings >
Internet > Network details: Text to show when a network configuraiton is
controlled by the primary user.">
On 2016/12/12 23:17:00, michaelpg wrote:
> configuration

Done.

https://codereview.chromium.org/2568593002/diff/20001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:1057: Network configuraiton is controlled by
<ph name="USER_EMAIL">$1<ex>joe@gmail.com</ex></ph>.
On 2016/12/12 23:17:00, michaelpg wrote:
> same

Done.

https://codereview.chromium.org/2568593002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2568593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:244: *
networkingPrivate.getProperties callback.
On 2016/12/12 23:17:00, michaelpg wrote:
> getState

Done.

https://codereview.chromium.org/2568593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:250: //
If |properties| becomes null (i.e. the network is no longer visible),
On 2016/12/12 23:17:00, michaelpg wrote:
> |state|?

Done.

https://codereview.chromium.org/2568593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:312:
return !!this.primaryUserEmail_;
On 2016/12/12 23:17:00, michaelpg wrote:
> Can we use loadTimeData.getBoolean('isSecondaryUser'), maybe as its own
> property? isSecondaryUser_ never changes, so we shouldn't have to set up all
the
> event listeners and such that Polymer would create for this binding.
> 
> Also, primaryUserEmail_ might not be set properly in situations like CrOS on
> Linux or tests, maybe.

In that case I may as well make this a property, which is probably simpler
anyway. Done.

[michaelpg, 2016-12-13 23:49:54]

lgtm

https://codereview.chromium.org/2568593002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2568593002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:40: /**
Whether the user is a secondary user. */
nit: @private

[stevenjb, 2016-12-14 00:11:20]

https://codereview.chromium.org/2568593002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2568593002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:40: /**
Whether the user is a secondary user. */
On 2016/12/13 23:49:54, michaelpg wrote:
> nit: @private

Done.

[stevenjb, 2016-12-14 00:11:47]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-12-14 00:11:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2568593002/#ps60001
(title: "Add @private")

[commit-bot: I haz the power, 2016-12-14 00:12:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:26:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481674307481560,
"parent_rev": "0b69d5ba93a8fb594774b0c35e1c3aced23703dc", "commit_rev":
"ad90db25f38018c7c97cd6e506f7d72fc1e41b42"}

[commit-bot: I haz the power, 2016-12-14 01:26:23]

Description was changed from

==========
MD Settings: Internet: Only show detailed info for primary user.

BUG=648498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Only show detailed info for primary user.

BUG=648498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2568593002
==========

[commit-bot: I haz the power, 2016-12-14 01:26:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 01:30:18]

Description was changed from

==========
MD Settings: Internet: Only show detailed info for primary user.

BUG=648498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2568593002
==========

to

==========
MD Settings: Internet: Only show detailed info for primary user.

BUG=648498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/bfeca7cd9b6e45c1e00cb86dd44eac76f2e082b9
Cr-Commit-Position: refs/heads/master@{#438379}
==========

[commit-bot: I haz the power, 2016-12-14 01:30:19]

Patchset 4 (id:??) landed as
https://crrev.com/bfeca7cd9b6e45c1e00cb86dd44eac76f2e082b9
Cr-Commit-Position: refs/heads/master@{#438379}