devtools: Split Network.getCookies into Network.get{All,}Cookies

devtools: Split Network.getCookies into Network.get{All,}Cookies

This patch splits the Network.getCookies command into
Network.getCookies, which returns the cookies for the current URL and
Network.getAllCookies, which returns all the cookies in the cookie jar.

BUG=668932, 166637
Committed: https://crrev.com/9349e8fc1900cab593c7b3c17bc8d840fcae6f8d
Cr-Commit-Position: refs/heads/master@{#438198}

[Sami, 2016-12-09 14:31:41]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[Sami, 2016-12-09 14:31:52]

Description was changed from

==========
devtools: Split Network.getCookies into Network.get{All,}Cookies

This patch splits the Network.getCookies command into
Network.getCookies, which returns the cookies for the current URL and
Network.getAllCookies, which returns all the cookies in the cookie jar.

BUG=668932,166637
==========

to

==========
devtools: Split Network.getCookies into Network.get{All,}Cookies

This patch splits the Network.getCookies command into
Network.getCookies, which returns the cookies for the current URL and
Network.getAllCookies, which returns all the cookies in the cookie jar.

BUG=668932,166637
==========

[Sami, 2016-12-09 14:31:52]

skyostil@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[commit-bot: I haz the power, 2016-12-09 14:31:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 16:23:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 16:23:16]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-09 21:30:17]

Thanks! lgtm

[Sami, 2016-12-12 11:01:36]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-12-12 11:02:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 12:55:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 12:55:07]

Failed to apply patch for
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:
While running git apply --index -p1;
  error: patch failed:
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:661
  error:
content/browser/devtools/protocol/devtools_protocol_handler_generator.py: patch
does not apply

Patch:      
content/browser/devtools/protocol/devtools_protocol_handler_generator.py
Index: content/browser/devtools/protocol/devtools_protocol_handler_generator.py
diff --git
a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
index
ca6f1ca887fbf4090c2b258045396b82fd4cb09b..18e23fd686a0107607b4b01815f67af19df28913
100755
--- a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
+++ b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
@@ -652,6 +652,7 @@ browser_commands_list = [
     "Network.clearBrowserCache",
     "Network.clearBrowserCookies",
     "Network.getCookies",
+    "Network.getAllCookies",
     "Network.deleteCookie",
     "Network.setCookie",
     "Network.canEmulateNetworkConditions",
@@ -661,6 +662,7 @@ async_commands_list = [
     "Page.searchInResource",
     "Page.captureScreenshot",
     "Network.getCookies",
+    "Network.getAllCookies",
     "Network.deleteCookie",
     "Network.setCookie",
     "Input.synthesizePinchGesture",

[pfeldman, 2016-12-12 20:45:59]

Thanks!

[Sami, 2016-12-13 15:18:09]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-12-13 15:18:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2568503002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-13 15:18:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 17:12:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481642289671870,
"parent_rev": "334c786f4ac4fdd6df634ecc970b33dfc0702d79", "commit_rev":
"f9662fa79feb0a0e523ca5ebf3fa6bf4d01f0705"}

[commit-bot: I haz the power, 2016-12-13 17:13:07]

Description was changed from

==========
devtools: Split Network.getCookies into Network.get{All,}Cookies

This patch splits the Network.getCookies command into
Network.getCookies, which returns the cookies for the current URL and
Network.getAllCookies, which returns all the cookies in the cookie jar.

BUG=668932,166637
==========

to

==========
devtools: Split Network.getCookies into Network.get{All,}Cookies

This patch splits the Network.getCookies command into
Network.getCookies, which returns the cookies for the current URL and
Network.getAllCookies, which returns all the cookies in the cookie jar.

BUG=668932,166637

Review-Url: https://codereview.chromium.org/2568503002
==========

[commit-bot: I haz the power, 2016-12-13 17:13:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 17:16:15]

Description was changed from

==========
devtools: Split Network.getCookies into Network.get{All,}Cookies

This patch splits the Network.getCookies command into
Network.getCookies, which returns the cookies for the current URL and
Network.getAllCookies, which returns all the cookies in the cookie jar.

BUG=668932,166637

Review-Url: https://codereview.chromium.org/2568503002
==========

to

==========
devtools: Split Network.getCookies into Network.get{All,}Cookies

This patch splits the Network.getCookies command into
Network.getCookies, which returns the cookies for the current URL and
Network.getAllCookies, which returns all the cookies in the cookie jar.

BUG=668932,166637

Committed: https://crrev.com/9349e8fc1900cab593c7b3c17bc8d840fcae6f8d
Cr-Commit-Position: refs/heads/master@{#438198}
==========

[commit-bot: I haz the power, 2016-12-13 17:16:16]

Patchset 2 (id:??) landed as
https://crrev.com/9349e8fc1900cab593c7b3c17bc8d840fcae6f8d
Cr-Commit-Position: refs/heads/master@{#438198}