Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2568493002: [wasm] Only do SIMD lowering if SIMD is present in the graph. (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
Reviewers:
bradnelson, bradn, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Only do SIMD lowering if SIMD is present in the graph. R=bradnelson@chromium.org, ahaas@chromium.org BUG= Committed: https://crrev.com/768acf683bd5059f467c72700a9c3d36b863faa8 Cr-Commit-Position: refs/heads/master@{#41621}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M src/compiler/wasm-compiler.h View 3 chunks +11 lines, -8 lines 1 comment Download
M src/compiler/wasm-compiler.cc View 6 chunks +16 lines, -14 lines 1 comment Download

Messages

Total messages: 16 (10 generated)
titzer
PTAL
4 years ago (2016-12-09 14:29:06 UTC) #3
bradn
lgtm https://codereview.chromium.org/2568493002/diff/1/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/2568493002/diff/1/src/compiler/wasm-compiler.cc#newcode3450 src/compiler/wasm-compiler.cc:3450: if (builder.has_simd() && !CpuFeatures::SupportsSimd128()) { Oops, sorry thought ...
4 years ago (2016-12-09 14:49:05 UTC) #7
ahaas
lgtm
4 years ago (2016-12-09 14:51:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568493002/1
4 years ago (2016-12-09 14:55:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 14:57:04 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-09 14:57:19 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/768acf683bd5059f467c72700a9c3d36b863faa8
Cr-Commit-Position: refs/heads/master@{#41621}

Powered by Google App Engine
This is Rietveld 408576698