Remove some theme images that are not used any more.

Remove some theme images that are not used any more.

These aren't used by the default theme, which renders programmatically
or with colors. (For example, the ntp background image was a 42x42
white square, but we don't need it because we set the bg color to
white.)

I left the IDR_s in place because they're still needed to identify
custom theme images. We could replace them with a C++ enum, but since
they occupy the same namespace as other themed/not-themed images (ints),
leaving them here seems the best way to avoid potential collisions.

BUG=522168
Committed: https://crrev.com/5cc5609d072e90e2b1fe5d9de04bf00d45c5a5c6
Cr-Commit-Position: refs/heads/master@{#438989}

[Evan Stade, 2016-12-13 16:46:47]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 16:47:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-12-13 16:51:19]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-12-13 16:51:21]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[commit-bot: I haz the power, 2016-12-13 16:51:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-12-13 16:54:12]

wait, hold up. At least one of these is used as a base for tinting for custom
themes.

[Evan Stade, 2016-12-13 17:32:41]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 17:33:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-12-13 17:40:10]

estade@chromium.org changed reviewers:
+ bsep@chromium.org

[Evan Stade, 2016-12-13 17:40:11]

ok, PTAL Peter and Bret.

https://codereview.chromium.org/2568403004/diff/40001/chrome/browser/themes/b...
File chrome/browser/themes/browser_theme_pack.cc (left):

https://codereview.chromium.org/2568403004/diff/40001/chrome/browser/themes/b...
chrome/browser/themes/browser_theme_pack.cc:1254: int prs_base_id = 0;
explanation of changes to this function.

1) This was a rather pointless assignment and then check that's always true.
2) we only need/use prs_base_id if there's no image for prs_id

https://codereview.chromium.org/2568403004/diff/40001/chrome/browser/themes/b...
chrome/browser/themes/browser_theme_pack.cc:1280: frame = gfx::Image();
3) this was a pointless assignment. This entire branch could be rewritten

else if (prs_base_id != PRS_THEME_FRAME_OVERLAY) {
  frame = rb.GetImageNamed(IDR_THEME_FRAME);
}

4) however, even that I found pointless. I tried dozens of seemingly
frame-image-less themes and couldn't find one that didn't specify either a frame
image or a frame color (themes with solid color frames usually provide an
image). The only one I could find that was even hitting this code path was [1]
and it does fine without it, falling back to frame color.

bonus justification: for the use_ash condition, this was already using
notused.png, i.e. not doing anything, and to my knowledge we don't have any
outstanding bug reports.

[1]
https://chrome.google.com/webstore/detail/kalis-lake-meade-simple-t/lajcphnmk...

[commit-bot: I haz the power, 2016-12-13 18:37:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 18:37:18]

Dry run: This issue passed the CQ dry run.

[Bret, 2016-12-13 22:58:46]

lgtm

[Evan Stade, 2016-12-14 04:09:59]

estade@chromium.org changed reviewers:
+ oshima@chromium.org

[Evan Stade, 2016-12-14 04:10:00]

Peter, in case I wasn't clear, I was hoping you'd take a look at this change,
but if you want to defer to Bret's review that's ok too.

also +oshima for OWNERS of c/a/t.

[Peter Kasting, 2016-12-14 04:27:54]

Yeah, I just hadn't reviewed yet.

LGTM

https://codereview.chromium.org/2568403004/diff/40001/chrome/browser/themes/b...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/2568403004/diff/40001/chrome/browser/themes/b...
chrome/browser/themes/browser_theme_pack.cc:1253: // thing and just use theme
colors.
Nit: The last sentence isn't really about what this code does, but what some
caller does.  If it says anything, it should maybe be "If that's not provided,
the caller will fall back to using the frame colors instead."

https://codereview.chromium.org/2568403004/diff/40001/chrome/browser/themes/b...
chrome/browser/themes/browser_theme_pack.cc:1265: }
Nit: This isn't much better (it's just as long), but it does avoid duplicating
the logic for "if there is no incognito image, fall back to the normal image",
which seems nice.

      if (prs_base_id == PRS_THEME_FRAME_OVERLAY_INACTIVE) {
        prs_base_id = PRS_THEME_FRAME_OVERLAY;
      } else if (prs_base_id == PRS_THEME_FRAME_INACTIVE) {
        prs_base_id = PRS_THEME_FRAME;
      } else {
        if (prs_base_id == PRS_THEME_FRAME_INCOGNITO_INACTIVE)
          prs_base_id = PRS_THEME_FRAME_INCOGNITO;
        if (prs_base_id == PRS_THEME_FRAME_INCOGNITO &&
            !images->count(PRS_THEME_FRAME_INCOGNITO))
          prs_base_id = PRS_THEME_FRAME;
      }

[oshima, 2016-12-14 21:42:35]

c/a/theme lgtm

[Evan Stade, 2016-12-15 03:31:09]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-12-15 03:31:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, bsep@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2568403004/#ps60001
(title: "simplifaction")

[Evan Stade, 2016-12-15 03:31:14]

https://codereview.chromium.org/2568403004/diff/40001/chrome/browser/themes/b...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/2568403004/diff/40001/chrome/browser/themes/b...
chrome/browser/themes/browser_theme_pack.cc:1253: // thing and just use theme
colors.
On 2016/12/14 04:27:54, Peter Kasting wrote:
> Nit: The last sentence isn't really about what this code does, but what some
> caller does.  If it says anything, it should maybe be "If that's not provided,
> the caller will fall back to using the frame colors instead."

Done.

https://codereview.chromium.org/2568403004/diff/40001/chrome/browser/themes/b...
chrome/browser/themes/browser_theme_pack.cc:1265: }
On 2016/12/14 04:27:54, Peter Kasting wrote:
> Nit: This isn't much better (it's just as long), but it does avoid duplicating
> the logic for "if there is no incognito image, fall back to the normal image",
> which seems nice.
> 
>       if (prs_base_id == PRS_THEME_FRAME_OVERLAY_INACTIVE) {
>         prs_base_id = PRS_THEME_FRAME_OVERLAY;
>       } else if (prs_base_id == PRS_THEME_FRAME_INACTIVE) {
>         prs_base_id = PRS_THEME_FRAME;
>       } else {
>         if (prs_base_id == PRS_THEME_FRAME_INCOGNITO_INACTIVE)
>           prs_base_id = PRS_THEME_FRAME_INCOGNITO;
>         if (prs_base_id == PRS_THEME_FRAME_INCOGNITO &&
>             !images->count(PRS_THEME_FRAME_INCOGNITO))
>           prs_base_id = PRS_THEME_FRAME;
>       }

I further refined this for simplicity.

[commit-bot: I haz the power, 2016-12-15 03:31:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 04:00:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 04:01:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-12-15 23:33:52]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-12-15 23:33:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, bsep@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2568403004/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-12-15 23:34:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 02:21:12]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481844832680410,
"parent_rev": "4b02220b85e6051cbc6b178401b5d836bd958059", "commit_rev":
"d5d6042d6291a0171b0ae8dec0035887c7635905"}

[commit-bot: I haz the power, 2016-12-16 02:21:39]

Description was changed from

==========
Remove some theme images that are not used any more.

These aren't used by the default theme, which renders programmatically
or with colors. (For example, the ntp background image was a 42x42
white square, but we don't need it because we set the bg color to
white.)

I left the IDR_s in place because they're still needed to identify
custom theme images. We could replace them with a C++ enum, but since
they occupy the same namespace as other themed/not-themed images (ints),
leaving them here seems the best way to avoid potential collisions.

BUG=522168
==========

to

==========
Remove some theme images that are not used any more.

These aren't used by the default theme, which renders programmatically
or with colors. (For example, the ntp background image was a 42x42
white square, but we don't need it because we set the bg color to
white.)

I left the IDR_s in place because they're still needed to identify
custom theme images. We could replace them with a C++ enum, but since
they occupy the same namespace as other themed/not-themed images (ints),
leaving them here seems the best way to avoid potential collisions.

BUG=522168

Review-Url: https://codereview.chromium.org/2568403004
==========

[commit-bot: I haz the power, 2016-12-16 02:21:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-16 02:23:36]

Description was changed from

==========
Remove some theme images that are not used any more.

These aren't used by the default theme, which renders programmatically
or with colors. (For example, the ntp background image was a 42x42
white square, but we don't need it because we set the bg color to
white.)

I left the IDR_s in place because they're still needed to identify
custom theme images. We could replace them with a C++ enum, but since
they occupy the same namespace as other themed/not-themed images (ints),
leaving them here seems the best way to avoid potential collisions.

BUG=522168

Review-Url: https://codereview.chromium.org/2568403004
==========

to

==========
Remove some theme images that are not used any more.

These aren't used by the default theme, which renders programmatically
or with colors. (For example, the ntp background image was a 42x42
white square, but we don't need it because we set the bg color to
white.)

I left the IDR_s in place because they're still needed to identify
custom theme images. We could replace them with a C++ enum, but since
they occupy the same namespace as other themed/not-themed images (ints),
leaving them here seems the best way to avoid potential collisions.

BUG=522168

Committed: https://crrev.com/5cc5609d072e90e2b1fe5d9de04bf00d45c5a5c6
Cr-Commit-Position: refs/heads/master@{#438989}
==========

[commit-bot: I haz the power, 2016-12-16 02:23:37]

Patchset 5 (id:??) landed as
https://crrev.com/5cc5609d072e90e2b1fe5d9de04bf00d45c5a5c6
Cr-Commit-Position: refs/heads/master@{#438989}