Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2568403002: [Bindings][Refactoring] Remove attribute filters from .tmpl files (Closed)

Created:
4 years ago by peria
Modified:
4 years ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove attribute filters from .tmpl files. We rarely handle all attributes in a loop. Instead, we have filters to iterate only on accessors, on data type attributes, so on. It is very confusing to have all attributes in a variable in .py and filter them in .tmpl files. This CL applies such filters in pre-process in .py and uses more descriptive names in template contexts. It keeps 'attributes' for some usages, which are to be replaced. This is a refactoring in template engine, so it does not change generated code. BUG=650150 Committed: https://crrev.com/9b9858514e087acbcf12846f3cd77220ba964f14 Cr-Commit-Position: refs/heads/master@{#438099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -35 lines) Patch
M third_party/WebKit/Source/bindings/scripts/code_generator.py View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 3 chunks +9 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl View 7 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
peria
PTL
4 years ago (2016-12-13 05:18:45 UTC) #6
haraken
LGTM
4 years ago (2016-12-13 05:33:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568403002/1
4 years ago (2016-12-13 05:34:16 UTC) #9
bashi
lgtm
4 years ago (2016-12-13 05:36:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 08:26:29 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9b9858514e087acbcf12846f3cd77220ba964f14 Cr-Commit-Position: refs/heads/master@{#438099}
4 years ago (2016-12-13 08:29:26 UTC) #15
Yuki
4 years ago (2016-12-14 05:58:19 UTC) #16
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698