Scale scrollbar width in popup properly

Scale scrollbar width in popup properly

Implement missing windowToViewportScalar on PagePopupChromeClient

BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html

Committed: https://crrev.com/1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d
Cr-Commit-Position: refs/heads/master@{#438381}

[oshima, 2016-12-13 17:31:11]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 17:32:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-12-13 19:48:46]

Description was changed from

==========
Fix scrollbar width in popup

BUG=673109
==========

to

==========
Fix scrollbar width in popup

BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html
==========

[oshima, 2016-12-13 19:49:16]

Description was changed from

==========
Fix scrollbar width in popup

BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html
==========

to

==========
Fix scrollbar width in popup

Implmenet missing windowToViewportScalar on 


BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html
==========

[oshima, 2016-12-13 19:49:39]

Description was changed from

==========
Fix scrollbar width in popup

Implmenet missing windowToViewportScalar on 


BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html
==========

to

==========
Fix scrollbar width in popup

Implement missing windowToViewportScalar on PagePopupChromeClient

BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html
==========

[oshima, 2016-12-13 19:49:43]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2016-12-13 19:49:50]

oshima@chromium.org changed reviewers:
+ tkent@chromium.org

[commit-bot: I haz the power, 2016-12-13 19:50:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-12-13 20:30:04]

Description was changed from

==========
Fix scrollbar width in popup

Implement missing windowToViewportScalar on PagePopupChromeClient

BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html
==========

to

==========
Scale scrollbar width in popup properly

Implement missing windowToViewportScalar on PagePopupChromeClient

BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html
==========

[commit-bot: I haz the power, 2016-12-13 21:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 21:59:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2016-12-13 23:08:41]

lgtm

https://codereview.chromium.org/2568353003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2568353003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:2033: crbug.com/673109 [ Linux
Win ]
virtual/scalefactor200/fast/hidpi/static/popup-menu-with-scrollbar-appearance.html
[ NeedsRebaseline ]
Mac also needs rebaseline for this.

scalefactor150 and scalefactor200withzoom are skipped on Mac.

[oshima, 2016-12-14 00:02:58]

https://codereview.chromium.org/2568353003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2568353003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:2033: crbug.com/673109 [ Linux
Win ]
virtual/scalefactor200/fast/hidpi/static/popup-menu-with-scrollbar-appearance.html
[ NeedsRebaseline ]
On 2016/12/13 23:08:40, tkent wrote:
> Mac also needs rebaseline for this.
> 
> scalefactor150 and scalefactor200withzoom are skipped on Mac.

Done.

[oshima, 2016-12-14 00:03:20]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-12-14 00:03:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2568353003/#ps40001
(title: "rebase mac")

[commit-bot: I haz the power, 2016-12-14 00:03:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:36:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481673800565890,
"parent_rev": "ad8b6f62403653f77a731fce36618e4e7fae2d94", "commit_rev":
"ef90340ff39466bbd5b0f13a48f74235c3807872"}

[commit-bot: I haz the power, 2016-12-14 01:37:42]

Description was changed from

==========
Scale scrollbar width in popup properly

Implement missing windowToViewportScalar on PagePopupChromeClient

BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html
==========

to

==========
Scale scrollbar width in popup properly

Implement missing windowToViewportScalar on PagePopupChromeClient

BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html

Review-Url: https://codereview.chromium.org/2568353003
==========

[commit-bot: I haz the power, 2016-12-14 01:37:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-14 01:40:36]

Description was changed from

==========
Scale scrollbar width in popup properly

Implement missing windowToViewportScalar on PagePopupChromeClient

BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html

Review-Url: https://codereview.chromium.org/2568353003
==========

to

==========
Scale scrollbar width in popup properly

Implement missing windowToViewportScalar on PagePopupChromeClient

BUG=673109
TEST=popup-menu-with-scrollbar-appearance.html

Committed: https://crrev.com/1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d
Cr-Commit-Position: refs/heads/master@{#438381}
==========

[commit-bot: I haz the power, 2016-12-14 01:40:39]

Patchset 3 (id:??) landed as
https://crrev.com/1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d
Cr-Commit-Position: refs/heads/master@{#438381}