Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2568343002:
GetMimeTypeAndCharset at once (Closed)
|
Created:
4 years ago by kouhei (in TOK) Modified:
4 years ago CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionGetMimeTypeAndCharset at once
HttpResponseHeaders::Get{MimeType,Charset} calls GetMimeTypeAndCharset internally
and discards the other.
As we are going to use both in parseMultipartHeadersFromBody, we should call it directly.
BUG=None
Committed: https://crrev.com/4e2660f55d843d68afde9d55632c4335ca28f550
Cr-Commit-Position: refs/heads/master@{#438049}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
kouhei@chromium.org changed reviewers: + haraken@chromium.org, tyoshino@chormium.org, yhirano@chromium.org
kouhei@chromium.org changed required reviewers: + haraken@chromium.org
yhirano,tyoshino: PTAL haraken: for platform OWNER
The CQ bit was checked by kouhei@chromium.org to run a CQ dry run
Description was changed from
==========
GetMimeTypeAndCharset at once
HttpResponseHeaders::Get{MimeType,Charset} calls GetMimeTypeAndCharset
internally
and discards the other.
As we are going to use both in parseMultipartHeadersFromBody, we should call it
directly.
BUG=None
==========
to
==========
GetMimeTypeAndCharset at once
HttpResponseHeaders::Get{MimeType,Charset} calls GetMimeTypeAndCharset
internally
and discards the other.
As we are going to use both in parseMultipartHeadersFromBody, we should call it
directly.
BUG=None
==========
kouhei@chromium.org changed reviewers: + tyoshino@chromium.org - tyoshino@chormium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481601537088350, "parent_rev":
"312fc391430edb1ef1836bf4c054f80f206912ac", "commit_rev":
"0772dbe03285b7db3cb5ef4205c695a69e101800"}
Message was sent while issue was closed.
Description was changed from
==========
GetMimeTypeAndCharset at once
HttpResponseHeaders::Get{MimeType,Charset} calls GetMimeTypeAndCharset
internally
and discards the other.
As we are going to use both in parseMultipartHeadersFromBody, we should call it
directly.
BUG=None
==========
to
==========
GetMimeTypeAndCharset at once
HttpResponseHeaders::Get{MimeType,Charset} calls GetMimeTypeAndCharset
internally
and discards the other.
As we are going to use both in parseMultipartHeadersFromBody, we should call it
directly.
BUG=None
Review-Url: https://codereview.chromium.org/2568343002
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
GetMimeTypeAndCharset at once
HttpResponseHeaders::Get{MimeType,Charset} calls GetMimeTypeAndCharset
internally
and discards the other.
As we are going to use both in parseMultipartHeadersFromBody, we should call it
directly.
BUG=None
Review-Url: https://codereview.chromium.org/2568343002
==========
to
==========
GetMimeTypeAndCharset at once
HttpResponseHeaders::Get{MimeType,Charset} calls GetMimeTypeAndCharset
internally
and discards the other.
As we are going to use both in parseMultipartHeadersFromBody, we should call it
directly.
BUG=None
Committed: https://crrev.com/4e2660f55d843d68afde9d55632c4335ca28f550
Cr-Commit-Position: refs/heads/master@{#438049}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4e2660f55d843d68afde9d55632c4335ca28f550 Cr-Commit-Position: refs/heads/master@{#438049}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
