Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2568333004: SELECT element: Do not update popup content if CharacterData or attribute value is not changed. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT element: Do not update popup content if CharacterData or attribute value is not changed. BUG=667148 Committed: https://crrev.com/40feeb134491de74bf14d3fa8aa2dfe05a28d31e Cr-Commit-Position: refs/heads/master@{#438462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tkent
Hattori-san, would you review this please?
4 years ago (2016-12-14 02:16:40 UTC) #4
keishi
LGTM
4 years ago (2016-12-14 08:23:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568333004/1
4 years ago (2016-12-14 08:24:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 08:28:53 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 08:30:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40feeb134491de74bf14d3fa8aa2dfe05a28d31e
Cr-Commit-Position: refs/heads/master@{#438462}

Powered by Google App Engine
This is Rietveld 408576698