Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2568303008: [source-positions] make the SourcePositionInfo constructor actually compute position info (Closed)

Created:
4 years ago by Tobias Tebbi
Modified:
4 years ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[source-positions] make the SourcePositionInfo constructor actually compute position info R=danno@chromium.org BUG= Committed: https://crrev.com/859414da4c413da6732475ce92d6b83fb1bb8fb3 Cr-Commit-Position: refs/heads/master@{#41693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M src/source-position.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/source-position.cc View 3 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Tobias Tebbi
This should fix a regression for fullcodegen source positions introduced by your usage of the ...
4 years ago (2016-12-14 11:07:25 UTC) #1
danno
Thanks a lot for fixing this! Very cool. lgtm.
4 years ago (2016-12-14 11:42:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568303008/1
4 years ago (2016-12-14 12:23:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 12:57:50 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-14 12:58:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/859414da4c413da6732475ce92d6b83fb1bb8fb3
Cr-Commit-Position: refs/heads/master@{#41693}

Powered by Google App Engine
This is Rietveld 408576698