Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: grit/tool/build_unittest.py

Issue 25683011: Add the ability to generate a depfile when running grit build. (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master
Patch Set: add test, respond to comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« grit/tool/build.py ('K') | « grit/tool/build.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit/tool/build_unittest.py
diff --git a/grit/tool/build_unittest.py b/grit/tool/build_unittest.py
index 4ca4740fc629cf1f7395865bf7e71954cab98164..0b557ff39c8e4a9a79414ee8366089bae019fa3f 100644
--- a/grit/tool/build_unittest.py
+++ b/grit/tool/build_unittest.py
@@ -33,6 +33,29 @@ class BuildUnittest(unittest.TestCase):
self.extra_verbose = False
builder.Run(DummyOpts(), ['-o', output_dir])
+ def testGenerateDepFile(self):
+ output_dir = tempfile.mkdtemp()
+ builder = build.RcBuilder()
+ class DummyOpts(object):
+ def __init__(self):
+ self.input = util.PathFromRoot('grit/testdata/substitute.grd')
+ self.verbose = False
+ self.extra_verbose = False
+ builder.Run(DummyOpts(), ['-o', output_dir, '--dep-dir', output_dir])
+
+ expected_dep_file = os.path.join(output_dir, 'substitute.grd.d')
+ self.failUnless(os.path.isfile(expected_dep_file))
+ with open(expected_dep_file) as f:
+ line = f.readline()
+ (dep_file_name, deps_string) = line.split(': ')
+ deps = deps_string.split(' ')
+ self.failUnlessEqual(os.path.abspath(expected_dep_file),
+ os.path.abspath(os.path.join(output_dir, dep_file_name)),
+ "depfile should refer to itself as the depended upon file")
+ self.failUnlessEqual(1, len(deps))
+ self.failUnlessEqual(deps[0],
+ util.PathFromRoot('grit/testdata/substitute.xmb'))
+
if __name__ == '__main__':
unittest.main()
« grit/tool/build.py ('K') | « grit/tool/build.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698