Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: grit/tool/build.py

Issue 25683011: Add the ability to generate a depfile when running grit build. (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master
Patch Set: add test, respond to comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | grit/tool/build_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit/tool/build.py
diff --git a/grit/tool/build.py b/grit/tool/build.py
index 596feb0a0f0d0ef7be4692375eb1fe62e9e6eb38..dbdbed474686dfe086bfd0f1ca0e726db912e117 100644
--- a/grit/tool/build.py
+++ b/grit/tool/build.py
@@ -98,7 +98,8 @@ are exported to translation interchange files (e.g. XMB files), etc.
first_ids_file = None
whitelist_filenames = []
target_platform = None
- (own_opts, args) = getopt.getopt(args, 'o:D:E:f:w:t:')
+ dep_dir = None
+ (own_opts, args) = getopt.getopt(args, 'o:D:E:f:w:t:', ('dep-dir=',))
for (key, val) in own_opts:
if key == '-o':
self.output_directory = val
@@ -117,6 +118,8 @@ are exported to translation interchange files (e.g. XMB files), etc.
whitelist_filenames.append(val)
elif key == '-t':
target_platform = val
+ elif key == '--dep-dir':
+ dep_dir = val
if len(args):
print 'This tool takes no tool-specific arguments.'
@@ -147,6 +150,10 @@ are exported to translation interchange files (e.g. XMB files), etc.
self.res.SetOutputLanguage('en')
self.res.RunGatherers()
self.Process()
+
+ if dep_dir:
+ self.GenerateDepfile(opts.input, dep_dir)
+
return 0
def __init__(self, defines=None):
@@ -251,9 +258,7 @@ are exported to translation interchange files (e.g. XMB files), etc.
self.res.SetDefines(self.defines)
# Make the output directory if it doesn't exist.
- outdir = os.path.split(output.GetOutputFilename())[0]
- if not os.path.exists(outdir):
- os.makedirs(outdir)
+ self.MakeDirectoriesTo(output.GetOutputFilename())
# Write the results to a temporary file and only overwrite the original
# if the file changed. This avoids unnecessary rebuilds.
@@ -304,3 +309,49 @@ are exported to translation interchange files (e.g. XMB files), etc.
if self.res.UberClique().HasMissingTranslations():
print self.res.UberClique().missing_translations_
sys.exit(-1)
+
+ def GenerateDepfile(self, input_filename, dep_dir):
+ '''Generate a depfile that contains the imlicit dependencies of the input
+ grd. The depfile will be in the same format as a makefile, and will contain
+ references to files relative to |dep_dir|. It will be put in the same
+ directory as the generated outputs.
+
+ For example, supposing we have three files in a directory src/
+
+ src/
+ blah.grd <- depends on input{1,2}.xtb
+ input1.xtb
+ input2.xtb
+
+ and we run
+
+ grit -i blah.grd -o ../out/gen --dep-dir ../out
+
+ from the directory src/ we will generate a depfile ../out/gen/blah.grd.d
+ that has the contents
+
+ gen/blah.grd.d: ../src/input1.xtb ../src/input2.xtb
+
+ Note that all paths in the depfile are relative to ../out, the dep-dir.
+ '''
+ depsfile_basename = os.path.basename(input_filename + '.d')
+ depfile = os.path.abspath(
+ os.path.join(self.output_directory, depsfile_basename))
+ dep_dir = os.path.abspath(dep_dir)
+ # The path prefix to prepend to dependencies in the depfile.
+ prefix = os.path.relpath(os.getcwd(), dep_dir)
+ # The path that the depfile refers to itself by.
+ self_ref_depfile = os.path.relpath(depfile, dep_dir)
+ infiles = self.res.GetInputFiles()
+ deps_text = ' '.join([os.path.join(prefix, i) for i in infiles])
+ depfile_contents = self_ref_depfile + ': ' + deps_text
+ self.MakeDirectoriesTo(depfile)
+ outfile = self.fo_create(depfile, 'wb')
+ outfile.writelines(depfile_contents)
Nico 2013/12/31 01:07:42 I'm currently looking at using this in gyp, and I'
+
+ @staticmethod
+ def MakeDirectoriesTo(file):
+ '''Creates directories necessary to contain |file|.'''
+ dir = os.path.split(file)[0]
+ if not os.path.exists(dir):
+ os.makedirs(dir)
« no previous file with comments | « no previous file | grit/tool/build_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698