Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Unified Diff: chrome/browser/resources/bluetooth_internals/device_table.js

Issue 2568283003: bluetooth: Add notification system to internals page. (Closed)
Patch Set: Remove margin, fix bug where snackbar dismisses if shown with no focus Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/bluetooth_internals/device_table.js
diff --git a/chrome/browser/resources/bluetooth_internals/device_table.js b/chrome/browser/resources/bluetooth_internals/device_table.js
index 0fe0291c8ee5bec4ab194b72256b91976a9cd934..be9e4b0ebcea62c9ce6e8a529f8d4b915756de8a 100644
--- a/chrome/browser/resources/bluetooth_internals/device_table.js
+++ b/chrome/browser/resources/bluetooth_internals/device_table.js
@@ -14,7 +14,6 @@ cr.define('device_table', function() {
SERVICES: 3,
CONNECTION_STATE: 4,
INSPECT_LINK: 5,
- CONNECTION_ERROR: 6,
};
/**
@@ -117,10 +116,6 @@ cr.define('device_table', function() {
// Make two extra cells for the inspect link and connect errors.
var inspectCell = row.insertCell();
- // TODO(crbug.com/663830): Replace connection error column with better
- // notification system.
- var connectErrorCell = row.insertCell();
-
var inspectLink = document.createElement('a', 'action-link');
inspectCell.appendChild(inspectLink);
inspectLink.addEventListener('click', function() {
@@ -172,12 +167,6 @@ cr.define('device_table', function() {
default: assert('case not handled');
}
- // TODO(crbug.com/663830): Replace connection error column with better
- // notification system.
- var connectErrorCell = row.cells[COLUMNS.CONNECTION_ERROR];
- connectErrorCell.textContent = device.connectionMessage;
- connectErrorCell.hidden = !device.connectionMessage;
-
// Update the properties based on the header field path.
for (var i = 0; i < this.headers_.length; i++) {
var header = this.headers_[i];

Powered by Google App Engine
This is Rietveld 408576698