Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4256)

Unified Diff: chrome/browser/resources/bluetooth_internals/device_collection.js

Issue 2568283003: bluetooth: Add notification system to internals page. (Closed)
Patch Set: Remove margin, fix bug where snackbar dismisses if shown with no focus Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/bluetooth_internals/device_collection.js
diff --git a/chrome/browser/resources/bluetooth_internals/device_collection.js b/chrome/browser/resources/bluetooth_internals/device_collection.js
index e7e6ae3c4254447ca74ad9224b40e06cd78f00ee..6f68ec9eb509eb80defd87635e3f4b864dd111ad 100644
--- a/chrome/browser/resources/bluetooth_internals/device_collection.js
+++ b/chrome/browser/resources/bluetooth_internals/device_collection.js
@@ -87,18 +87,11 @@ cr.define('device_collection', function() {
/**
* Updates the device connection status.
* @param {string} address The address of the device.
- * @param {number} status .
- * @param {?Error} opt_error Optional Error from connection.
+ * @param {number} status The new connection status.
*/
updateConnectionStatus: function(address, status, opt_error) {
- var message = (opt_error && opt_error.message) || '';
-
var device = assert(this.getByAddress(address), 'Device does not exist');
device.connectionStatus = status;
-
- // TODO(crbug.com/663830): Replace connection error column with better
- // notification system.
- device.connectionMessage = message;
this.updateIndex(this.indexOf(device));
},
};

Powered by Google App Engine
This is Rietveld 408576698