Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2568283002: Limiting SwiftShader compilation to x64 and x86 architectures (Closed)

Created:
4 years ago by sugoi1
Modified:
4 years ago
Reviewers:
Nico, sugoi
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limiting SwiftShader compilation to x64 and x86 architectures BUG=630728 Committed: https://crrev.com/a1b7b92265302228596afc9d0197664ed05a1ee9 Cr-Commit-Position: refs/heads/master@{#438145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
sugoi1
Adding some restrictions based on comments on this cl: https://codereview.chromium.org/2562463002/
4 years ago (2016-12-12 20:57:55 UTC) #2
Nico
lgtm
4 years ago (2016-12-12 21:02:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568283002/1
4 years ago (2016-12-13 12:05:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 12:53:21 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 12:57:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1b7b92265302228596afc9d0197664ed05a1ee9
Cr-Commit-Position: refs/heads/master@{#438145}

Powered by Google App Engine
This is Rietveld 408576698