|
|
Created:
4 years ago by Daniele Castagna Modified:
4 years ago CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionozone: Remove USE_LINEAR when allocating modeset buffers.
crrev.com/2533163002 changed the way we allocate modeset buffers.
Unfortunately the new use flags introduced a regression that makes it
not possible to pageflip from a modeset buffer to a buffer queue buffer.
This CL restores the old modeset buffer use flags in order to fix the
regression, while we work on a long term solution.
BUG=673026
TEST=manually tried the step described in the bug and verified it now works.
Committed: https://crrev.com/a17cccbc2dbf0bf2a0df1d98ebbc773491e3e4b4
Cr-Commit-Position: refs/heads/master@{#438193}
Patch Set 1 #
Messages
Total messages: 21 (13 generated)
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Description was changed from ========== ozone: Remove USE_LINEAR when allocating modeset buffer. crrev.com/2533163002 changed the way we allocate modeset buffers. Unfortunatly the new use flags introduced a regression that makes it not possible to pageflip from a modeset buffer to a buffer queue buffer. This CL restores the old modeset buffer use flags to fix the regression while we work on a long term solution. BUG=673026 TEST=manually tried the step described in the bug and verified it now works. ========== to ========== ozone: Remove USE_LINEAR when allocating modeset buffers. crrev.com/2533163002 changed the way we allocate modeset buffers. Unfortunatly the new use flags introduced a regression that makes it not possible to pageflip from a modeset buffer to a buffer queue buffer. This CL restores the old modeset buffer use flags in order to fix the regression, while we work on a long term solution. BUG=673026 TEST=manually tried the step described in the bug and verified it now works. ==========
dcastagna@chromium.org changed reviewers: + gurchetansingh@chromium.org, hoegsberg@chromium.org, marcheu@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== ozone: Remove USE_LINEAR when allocating modeset buffers. crrev.com/2533163002 changed the way we allocate modeset buffers. Unfortunatly the new use flags introduced a regression that makes it not possible to pageflip from a modeset buffer to a buffer queue buffer. This CL restores the old modeset buffer use flags in order to fix the regression, while we work on a long term solution. BUG=673026 TEST=manually tried the step described in the bug and verified it now works. ========== to ========== ozone: Remove USE_LINEAR when allocating modeset buffers. crrev.com/2533163002 changed the way we allocate modeset buffers. Unfortunately the new use flags introduced a regression that makes it not possible to pageflip from a modeset buffer to a buffer queue buffer. This CL restores the old modeset buffer use flags in order to fix the regression, while we work on a long term solution. BUG=673026 TEST=manually tried the step described in the bug and verified it now works. ==========
On 2016/12/13 01:55:16, Daniele Castagna wrote: lgtm
marcheu@google.com changed reviewers: + marcheu@google.com
lgtm
dcastagna@chromium.org changed reviewers: + dnicoara@chromium.org
+dnicoara for ownership.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1481647902390370, "parent_rev": "19eeef8a10fcea6f1fe6d427d9ed5d88c9798d97", "commit_rev": "dfc446fe026d6ddd9c571fb042c9262739e7f942"}
Message was sent while issue was closed.
Description was changed from ========== ozone: Remove USE_LINEAR when allocating modeset buffers. crrev.com/2533163002 changed the way we allocate modeset buffers. Unfortunately the new use flags introduced a regression that makes it not possible to pageflip from a modeset buffer to a buffer queue buffer. This CL restores the old modeset buffer use flags in order to fix the regression, while we work on a long term solution. BUG=673026 TEST=manually tried the step described in the bug and verified it now works. ========== to ========== ozone: Remove USE_LINEAR when allocating modeset buffers. crrev.com/2533163002 changed the way we allocate modeset buffers. Unfortunately the new use flags introduced a regression that makes it not possible to pageflip from a modeset buffer to a buffer queue buffer. This CL restores the old modeset buffer use flags in order to fix the regression, while we work on a long term solution. BUG=673026 TEST=manually tried the step described in the bug and verified it now works. Review-Url: https://codereview.chromium.org/2568243004 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== ozone: Remove USE_LINEAR when allocating modeset buffers. crrev.com/2533163002 changed the way we allocate modeset buffers. Unfortunately the new use flags introduced a regression that makes it not possible to pageflip from a modeset buffer to a buffer queue buffer. This CL restores the old modeset buffer use flags in order to fix the regression, while we work on a long term solution. BUG=673026 TEST=manually tried the step described in the bug and verified it now works. Review-Url: https://codereview.chromium.org/2568243004 ========== to ========== ozone: Remove USE_LINEAR when allocating modeset buffers. crrev.com/2533163002 changed the way we allocate modeset buffers. Unfortunately the new use flags introduced a regression that makes it not possible to pageflip from a modeset buffer to a buffer queue buffer. This CL restores the old modeset buffer use flags in order to fix the regression, while we work on a long term solution. BUG=673026 TEST=manually tried the step described in the bug and verified it now works. Committed: https://crrev.com/a17cccbc2dbf0bf2a0df1d98ebbc773491e3e4b4 Cr-Commit-Position: refs/heads/master@{#438193} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a17cccbc2dbf0bf2a0df1d98ebbc773491e3e4b4 Cr-Commit-Position: refs/heads/master@{#438193} |