Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2568243004: ozone: Remove USE_LINEAR when allocating modeset buffers. (Closed)

Created:
4 years ago by Daniele Castagna
Modified:
4 years ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Remove USE_LINEAR when allocating modeset buffers. crrev.com/2533163002 changed the way we allocate modeset buffers. Unfortunately the new use flags introduced a regression that makes it not possible to pageflip from a modeset buffer to a buffer queue buffer. This CL restores the old modeset buffer use flags in order to fix the regression, while we work on a long term solution. BUG=673026 TEST=manually tried the step described in the bug and verified it now works. Committed: https://crrev.com/a17cccbc2dbf0bf2a0df1d98ebbc773491e3e4b4 Cr-Commit-Position: refs/heads/master@{#438193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/ozone/platform/drm/gpu/drm_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Daniele Castagna
4 years ago (2016-12-13 01:55:16 UTC) #4
gurchetansingh
On 2016/12/13 01:55:16, Daniele Castagna wrote: lgtm
4 years ago (2016-12-13 01:57:10 UTC) #7
marcheu1
lgtm
4 years ago (2016-12-13 01:57:48 UTC) #9
Daniele Castagna
+dnicoara for ownership.
4 years ago (2016-12-13 02:08:23 UTC) #11
dnicoara
lgtm
4 years ago (2016-12-13 15:08:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568243004/1
4 years ago (2016-12-13 16:52:17 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 16:57:34 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-13 17:00:23 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a17cccbc2dbf0bf2a0df1d98ebbc773491e3e4b4
Cr-Commit-Position: refs/heads/master@{#438193}

Powered by Google App Engine
This is Rietveld 408576698