Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2568243002: [Payments] Fix the histogram_suffixes for the JourneyLogger. (Closed)

Created:
4 years ago by sebsg
Modified:
4 years ago
Reviewers:
jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Fix the histogram_suffixes for the JourneyLogger. The Logging uses "." as a separator so the histogram_suffixes in histograms.xml should use the same. BUG=673413 Committed: https://crrev.com/3ea4905d8da5484431a0efbd7456979cfe110d12 Cr-Commit-Position: refs/heads/master@{#438578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +14 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sebsg
Hi jwd@, could you please take a look? Thanks!
4 years ago (2016-12-12 18:57:02 UTC) #3
jwd
lgtm
4 years ago (2016-12-14 17:55:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568243002/1
4 years ago (2016-12-14 18:00:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 19:17:23 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-14 19:19:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ea4905d8da5484431a0efbd7456979cfe110d12
Cr-Commit-Position: refs/heads/master@{#438578}

Powered by Google App Engine
This is Rietveld 408576698