Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2568213002: [Cronet] Make some test infrastructure public rather than package-private. (Closed)

Created:
4 years ago by pauljensen
Modified:
4 years ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Make some test infrastructure public rather than package-private. There's no reason to have it package-private, and this prevents sharing with tests in other packages (e.g. org.chromium.net.urlconnection). BUG=629299 R=xunjieli CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Committed: https://crrev.com/0d18657bf57d4b0b6ee051883f6ffcf467879aed Cr-Commit-Position: refs/heads/master@{#437921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
pauljensen
Helen, PTAL, thank you!
4 years ago (2016-12-12 18:13:05 UTC) #2
xunjieli
lgtm
4 years ago (2016-12-12 20:16:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568213002/1
4 years ago (2016-12-12 20:18:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 21:40:54 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-12 21:44:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d18657bf57d4b0b6ee051883f6ffcf467879aed
Cr-Commit-Position: refs/heads/master@{#437921}

Powered by Google App Engine
This is Rietveld 408576698