|
|
Chromium Code Reviews
DescriptionChange "Read" header in Reading List
Change "Read" header to a phrase in reading to be clearer in all languages.
BUG=673335
Committed: https://crrev.com/a13fc8e6a3b66d2f08b4ffde5a59277c49fe366a
Cr-Commit-Position: refs/heads/master@{#438141}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Update text #Messages
Total messages: 32 (17 generated)
gambard@chromium.org changed reviewers: + jif@chromium.org
PTAL
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by gambard@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by gambard@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
gambard@chromium.org changed reviewers: + marq@chromium.org
marq@: PTAL as owner
https://codereview.chromium.org/2568163002/diff/1/ios/chrome/app/strings/ios_... File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2568163002/diff/1/ios/chrome/app/strings/ios_... ios/chrome/app/strings/ios_strings.grd:1078: Articles you've read I'm worried about consistency with the rest of the UI here; we have "Mark Read", "Mark Unread", and then "Unread", so it seems that in context "Read" is fine. Is the issue that this was mistranslated into a verb in some languages? This seems like the kind of thing that a UX writer would be able to help with.
https://codereview.chromium.org/2568163002/diff/1/ios/chrome/app/strings/ios_... File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2568163002/diff/1/ios/chrome/app/strings/ios_... ios/chrome/app/strings/ios_strings.grd:1078: Articles you've read On 2016/12/13 10:26:45, marq wrote: > I'm worried about consistency with the rest of the UI here; we have "Mark Read", > "Mark Unread", and then "Unread", so it seems that in context "Read" is fine. Is > the issue that this was mistranslated into a verb in some languages? > > This seems like the kind of thing that a UX writer would be able to help with. It was asked my mardini@ (see bug).
Per offline discussion, LGTM.
The CQ bit was checked by gambard@chromium.org
Thanks!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by gambard@chromium.org
The CQ bit was checked by gambard@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org, marq@chromium.org Link to the patchset: https://codereview.chromium.org/2568163002/#ps10002 (title: "Update text")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 10002, "attempt_start_ts": 1481630158296490,
"parent_rev": "40b7a8106edbf430f065dbd678bda50e54880194", "commit_rev":
"d3faa5eff7cfa13ec62c67ac2279bc74d1f3a119"}
Message was sent while issue was closed.
Description was changed from ========== Change "Read" header in Reading List Change "Read" header to a phrase in reading to be clearer in all languages. BUG=673335 ========== to ========== Change "Read" header in Reading List Change "Read" header to a phrase in reading to be clearer in all languages. BUG=673335 Review-Url: https://codereview.chromium.org/2568163002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:10002)
Message was sent while issue was closed.
Description was changed from ========== Change "Read" header in Reading List Change "Read" header to a phrase in reading to be clearer in all languages. BUG=673335 Review-Url: https://codereview.chromium.org/2568163002 ========== to ========== Change "Read" header in Reading List Change "Read" header to a phrase in reading to be clearer in all languages. BUG=673335 Committed: https://crrev.com/a13fc8e6a3b66d2f08b4ffde5a59277c49fe366a Cr-Commit-Position: refs/heads/master@{#438141} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a13fc8e6a3b66d2f08b4ffde5a59277c49fe366a Cr-Commit-Position: refs/heads/master@{#438141} |
