Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Issue 2568163002: Change "Read" header in Reading List (Closed)

Created:
4 years ago by gambard
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change "Read" header in Reading List Change "Read" header to a phrase in reading to be clearer in all languages. BUG=673335 Committed: https://crrev.com/a13fc8e6a3b66d2f08b4ffde5a59277c49fe366a Cr-Commit-Position: refs/heads/master@{#438141}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (17 generated)
gambard
PTAL
4 years ago (2016-12-12 16:09:24 UTC) #2
jif
lgtm
4 years ago (2016-12-12 16:58:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568163002/1
4 years ago (2016-12-12 16:59:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/323773)
4 years ago (2016-12-12 17:48:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568163002/1
4 years ago (2016-12-12 17:49:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/323811)
4 years ago (2016-12-12 18:10:44 UTC) #15
gambard
marq@: PTAL as owner
4 years ago (2016-12-13 10:21:40 UTC) #17
marq (ping after 24h)
https://codereview.chromium.org/2568163002/diff/1/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2568163002/diff/1/ios/chrome/app/strings/ios_strings.grd#newcode1078 ios/chrome/app/strings/ios_strings.grd:1078: Articles you've read I'm worried about consistency with the ...
4 years ago (2016-12-13 10:26:45 UTC) #18
gambard
https://codereview.chromium.org/2568163002/diff/1/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2568163002/diff/1/ios/chrome/app/strings/ios_strings.grd#newcode1078 ios/chrome/app/strings/ios_strings.grd:1078: Articles you've read On 2016/12/13 10:26:45, marq wrote: > ...
4 years ago (2016-12-13 10:28:46 UTC) #19
marq (ping after 24h)
Per offline discussion, LGTM.
4 years ago (2016-12-13 11:50:15 UTC) #20
gambard
Thanks!
4 years ago (2016-12-13 11:50:44 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568163002/1
4 years ago (2016-12-13 11:50:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568163002/10002
4 years ago (2016-12-13 11:56:15 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:10002)
4 years ago (2016-12-13 12:23:52 UTC) #30
commit-bot: I haz the power
4 years ago (2016-12-13 12:25:55 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a13fc8e6a3b66d2f08b4ffde5a59277c49fe366a
Cr-Commit-Position: refs/heads/master@{#438141}

Powered by Google App Engine
This is Rietveld 408576698