Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2568133006: Delete flaky metrics from the browser perf tests. (Closed)

Created:
4 years ago by phoglund_chromium
Modified:
4 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org, ehmaldonado_chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete flaky metrics from the browser perf tests. These metrics suffer from that they count the number of bytes since the beginning of the call, and average them during the 10-second measuring window after 60-seconds of warmup. This means that if there's any variance in the warmup period or the call gets established a little earlier or later, it will have a big impact on the numbers. I think we can just delete them. An alternative approach is to do like in https://codereview.chromium.org/2545553003 and subtract the count at the beginning of the measuring window, which means we effectively measure the bitrate during the measuring window. That's covered by the test added in that patch though, only it's going through the new stats API instead of the old one.So, let's just delete them from the old API for now. BUG=666725 CC=ehmaldonado@chromium.org R=kjellander@chromium.org Committed: https://crrev.com/054f7b1e4a7b3bbf8b1effb31ae4620918fe8787 Cr-Commit-Position: refs/heads/master@{#438474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M chrome/browser/media/webrtc/webrtc_browsertest_perf.cc View 4 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
phoglund_chromium
4 years ago (2016-12-13 16:56:01 UTC) #1
kjellander_chromium
lgtm
4 years ago (2016-12-14 07:24:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568133006/1
4 years ago (2016-12-14 09:02:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 09:48:56 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-14 09:50:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/054f7b1e4a7b3bbf8b1effb31ae4620918fe8787
Cr-Commit-Position: refs/heads/master@{#438474}

Powered by Google App Engine
This is Rietveld 408576698