Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)
Patch Set: Use addCompositionUnderlines() where I said I couldn't Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
index 3379cd7056db4c23901db604446b83ea5637d003..d31d2ecc93bad0d4d442464510f362cee61074a4 100644
--- a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
@@ -115,19 +115,23 @@ bool WebInputMethodControllerImpl::finishComposingText(
: InputMethodController::DoNotKeepSelection);
}
-bool WebInputMethodControllerImpl::commitText(const WebString& text,
- int relativeCaretPosition) {
+bool WebInputMethodControllerImpl::commitText(
+ const WebString& text,
+ const WebVector<WebCompositionUnderline>& underlines,
+ int relativeCaretPosition) {
UserGestureIndicator gestureIndicator(DocumentUserGestureToken::create(
frame()->document(), UserGestureToken::NewGesture));
if (WebPlugin* plugin = focusedPluginIfInputMethodSupported())
- return plugin->commitText(text, relativeCaretPosition);
+ return plugin->commitText(text, underlines, relativeCaretPosition);
// TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
// needs to be audited. See http://crbug.com/590369 for more details.
frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
- return inputMethodController().commitText(text, relativeCaretPosition);
+ return inputMethodController().commitText(
+ text, CompositionUnderlineVectorBuilder(underlines),
+ relativeCaretPosition);
}
WebTextInputInfo WebInputMethodControllerImpl::textInputInfo() {
« no previous file with comments | « third_party/WebKit/Source/web/WebInputMethodControllerImpl.h ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698