third_party/WebKit/Source/web/WebInputMethodControllerImpl.h - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebInputMethodControllerImpl.h

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Use addCompositionUnderlines() where I said I couldn't Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebInputMethodControllerImpl.h

diff --git a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.h b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.h

index 99488a97877603ffbcaa33907c38b34d0df13eb9..076933575cab1f0a234a654b645ede49cbb36acb 100644

--- a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.h

+++ b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.h

@@ -31,7 +31,9 @@ class WebInputMethodControllerImpl : public WebInputMethodController {

const WebVector<WebCompositionUnderline>& underlines,

int selectionStart,

int selectionEnd) override;

- bool commitText(const WebString& text, int relativeCaretPosition) override;

+ bool commitText(const WebString& text,

+ const WebVector<WebCompositionUnderline>& underlines,

+ int relativeCaretPosition) override;

bool finishComposingText(

ConfirmCompositionBehavior selectionBehavior) override;

WebTextInputInfo textInputInfo() override;