content/common/browser_plugin/browser_plugin_messages.h - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/browser_plugin/browser_plugin_messages.h

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Use addCompositionUnderlines() where I said I couldn't Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/browser_plugin/browser_plugin_messages.h

diff --git a/content/common/browser_plugin/browser_plugin_messages.h b/content/common/browser_plugin/browser_plugin_messages.h

index 81a54d595ed4b05617ef480abb623d6d55c2810f..2465c7896ae2f33f90ab921aa19de74c80e18164 100644

--- a/content/common/browser_plugin/browser_plugin_messages.h

+++ b/content/common/browser_plugin/browser_plugin_messages.h

@@ -74,10 +74,12 @@ IPC_MESSAGE_CONTROL5(

// This message is sent from BrowserPlugin to BrowserPluginGuest to notify that

// deleting the current composition and inserting specified text is requested.

-IPC_MESSAGE_CONTROL3(BrowserPluginHostMsg_ImeCommitText,

- int /* browser_plugin_instance_id */,

- std::string /* text */,

- int /* relative_cursor_pos */)

+IPC_MESSAGE_CONTROL4(

+ BrowserPluginHostMsg_ImeCommitText,

+ int /* browser_plugin_instance_id */,

+ std::string /* text */,

+ std::vector<blink::WebCompositionUnderline> /* underlines */,

+ int /* relative_cursor_pos */)

// This message is sent from BrowserPlugin to BrowserPluginGuest to notify that

// inserting the current composition is requested.