Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)
Patch Set: Use addCompositionUnderlines() where I said I couldn't Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 4f9fa204a0a5f8620f68621df1c634d809d0259b..d6b855b722d7b8e91ba1d37a5cb44c1f4a4b178c 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -2188,7 +2188,9 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
BOOL textInserted = NO;
if (textToBeInserted_.length() >
((hasMarkedText_ || oldHasMarkedText) ? 0u : 1u)) {
- widgetHost->ImeCommitText(textToBeInserted_, gfx::Range::InvalidRange(), 0);
+ widgetHost->ImeCommitText(textToBeInserted_,
+ std::vector<blink::WebCompositionUnderline>(),
+ gfx::Range::InvalidRange(), 0);
textInserted = YES;
}
@@ -3241,7 +3243,8 @@ extern NSString *NSTextInputReplacementRangeAttributeName;
gfx::Range replacement_range(replacementRange);
if (renderWidgetHostView_->GetActiveWidget()) {
renderWidgetHostView_->GetActiveWidget()->ImeCommitText(
- base::SysNSStringToUTF16(im_text), replacement_range, 0);
+ base::SysNSStringToUTF16(im_text),
+ std::vector<blink::WebCompositionUnderline>(), replacement_range, 0);
}
}
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/common/browser_plugin/browser_plugin_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698