src/inspector/js_protocol.json - Issue 2568083002: [inspector] add scope type for modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/inspector/js_protocol.json

Issue 2568083002: [inspector] add scope type for modules. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/inspector/debugger_script_externs.js ('K') | « src/inspector/injected-script-source.js ('k') | test/debugger/debug/harmony/modules-debug-scopes1.js » ('j') | test/debugger/debug/harmony/modules-debug-scopes1.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/inspector/js_protocol.json

diff --git a/src/inspector/js_protocol.json b/src/inspector/js_protocol.json

index dca7df274800f133f5df49de2be8a51af79db603..d0af43ded5988fd6983bea2906460a50ef5e60a8 100644

--- a/src/inspector/js_protocol.json

+++ b/src/inspector/js_protocol.json

@@ -453,7 +453,7 @@

"id": "Scope",

"type": "object",

"properties": [

- { "name": "type", "type": "string", "enum": ["global", "local", "with", "closure", "catch", "block", "script", "eval"], "description": "Scope type." },

+ { "name": "type", "type": "string", "enum": ["global", "local", "with", "closure", "catch", "block", "script", "eval", "module"], "description": "Scope type." },

dgozman 2016/12/12 23:22:18 Module is similar to global, correct? This patch n

{ "name": "object", "$ref": "Runtime.RemoteObject", "description": "Object representing the scope. For <code>global</code> and <code>with</code> scopes it represents the actual object; for the rest of the scopes, it is artificial transient object enumerating scope variables as its properties." },

{ "name": "name", "type": "string", "optional": true },

{ "name": "startLocation", "$ref": "Location", "optional": true, "description": "Location in the source code where scope starts" },