Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2568053002: [turbofan] Fix representation change from bit to tagged pointer. (Closed)

Created:
4 years ago by Jarin
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, mvstanton
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix representation change from bit to tagged pointer. BUG=chromium:673244 Committed: https://crrev.com/d024df4d22eb69904bfd29c7716ff0f2c16f5d18 Cr-Commit-Position: refs/heads/master@{#41634}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M src/compiler/representation-change.cc View 1 chunk +6 lines, -1 line 0 comments Download
A test/mjsunit/compiler/regress-673244.js View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Jarin
Could you take a look, please?
4 years ago (2016-12-12 09:21:57 UTC) #6
epertoso
lgtm
4 years ago (2016-12-12 09:31:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568053002/20001
4 years ago (2016-12-12 09:32:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 09:36:35 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 09:36:51 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d024df4d22eb69904bfd29c7716ff0f2c16f5d18
Cr-Commit-Position: refs/heads/master@{#41634}

Powered by Google App Engine
This is Rietveld 408576698