components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc - Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/content_suggestions_service.h ('K') | « components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h ('k') | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc » ('j') | components/ntp_snippets/remote/remote_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

index 68313a86c62baa1f5dda49aff8e369e6e988753b..487182eae5e73ee0d675eca3f7a5729879ca7efd 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

@@ -47,13 +47,12 @@ std::string GetPageId(const DictionaryValue& page_dictionary) {

PhysicalWebPageSuggestionsProvider::PhysicalWebPageSuggestionsProvider(

ContentSuggestionsProvider::Observer* observer,

- CategoryFactory* category_factory,

physical_web::PhysicalWebDataSource* physical_web_data_source,

PrefService* pref_service)

- : ContentSuggestionsProvider(observer, category_factory),

+ : ContentSuggestionsProvider(observer),

category_status_(CategoryStatus::AVAILABLE),

- provided_category_(category_factory->FromKnownCategory(

- KnownCategories::PHYSICAL_WEB_PAGES)),

+ provided_category_(

+ Category::FromKnownCategory(KnownCategories::PHYSICAL_WEB_PAGES)),

physical_web_data_source_(physical_web_data_source),

pref_service_(pref_service) {

observer->OnCategoryStatusChanged(this, provided_category_, category_status_);