components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h - Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/content_suggestions_service.h ('K') | « components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc ('k') | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('j') | components/ntp_snippets/remote/remote_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

index e0bc88859982ff0762b211a1d690b2feb0431fe6..0cb42b3a9044405241a0f85c47cbe897a286da5d 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

@@ -12,7 +12,6 @@

#include "base/callback_forward.h"

#include "base/values.h"

#include "components/ntp_snippets/category.h"

-#include "components/ntp_snippets/category_factory.h"

#include "components/ntp_snippets/category_status.h"

#include "components/ntp_snippets/content_suggestion.h"

#include "components/ntp_snippets/content_suggestions_provider.h"

@@ -31,7 +30,6 @@ class PhysicalWebPageSuggestionsProvider

public:

PhysicalWebPageSuggestionsProvider(

ContentSuggestionsProvider::Observer* observer,

- CategoryFactory* category_factory,

physical_web::PhysicalWebDataSource* physical_web_data_source,

PrefService* pref_service);

~PhysicalWebPageSuggestionsProvider() override;