Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc
diff --git a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc
index ef953e4e2fa58e7742719ff557e1407c2ee557e7..e966048a53873466266af5ef4814ee35ca3ca9df 100644
--- a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc
+++ b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc
@@ -11,7 +11,6 @@
#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
#include "components/ntp_snippets/category.h"
-#include "components/ntp_snippets/category_factory.h"
#include "components/ntp_snippets/content_suggestions_provider.h"
#include "components/ntp_snippets/mock_content_suggestions_provider_observer.h"
#include "components/prefs/testing_pref_service.h"
@@ -117,8 +116,7 @@ class ForeignSessionsSuggestionsProviderTest : public Test {
_, category(), CategoryStatus::AVAILABLE));
provider_ = base::MakeUnique<ForeignSessionsSuggestionsProvider>(
- &observer_, &category_factory_,
- std::move(fake_foreign_sessions_provider), &pref_service_);
+ &observer_, std::move(fake_foreign_sessions_provider), &pref_service_);
}
protected:
@@ -157,7 +155,7 @@ class ForeignSessionsSuggestionsProviderTest : public Test {
}
Category category() {
- return category_factory_.FromKnownCategory(KnownCategories::FOREIGN_TABS);
+ return Category::FromKnownCategory(KnownCategories::FOREIGN_TABS);
}
MockContentSuggestionsProviderObserver* observer() { return &observer_; }
@@ -165,7 +163,6 @@ class ForeignSessionsSuggestionsProviderTest : public Test {
private:
FakeForeignSessionsProvider* fake_foreign_sessions_provider_;
MockContentSuggestionsProviderObserver observer_;
- CategoryFactory category_factory_;
TestingPrefServiceSimple pref_service_;
std::unique_ptr<ForeignSessionsSuggestionsProvider> provider_;
std::map<int, std::unique_ptr<SyncedSession>> sessions_map_;

Powered by Google App Engine
This is Rietveld 408576698