Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
diff --git a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
index c82de24924310958969547df85e6175a02e42a23..7015f376817da6d53c7adc4b2b053a08548de00d 100644
--- a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
+++ b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
@@ -12,7 +12,7 @@
#include "base/strings/string_piece.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
-#include "components/ntp_snippets/category_factory.h"
+#include "components/ntp_snippets/category.h"
#include "components/ntp_snippets/category_info.h"
#include "components/ntp_snippets/content_suggestion.h"
#include "components/ntp_snippets/features.h"
@@ -161,13 +161,12 @@ struct ForeignSessionsSuggestionsProvider::SessionData {
ForeignSessionsSuggestionsProvider::ForeignSessionsSuggestionsProvider(
ContentSuggestionsProvider::Observer* observer,
- CategoryFactory* category_factory,
std::unique_ptr<ForeignSessionsProvider> foreign_sessions_provider,
PrefService* pref_service)
- : ContentSuggestionsProvider(observer, category_factory),
+ : ContentSuggestionsProvider(observer),
category_status_(CategoryStatus::INITIALIZING),
provided_category_(
- category_factory->FromKnownCategory(KnownCategories::FOREIGN_TABS)),
+ Category::FromKnownCategory(KnownCategories::FOREIGN_TABS)),
foreign_sessions_provider_(std::move(foreign_sessions_provider)),
pref_service_(pref_service) {
foreign_sessions_provider_->SubscribeForForeignTabChange(

Powered by Google App Engine
This is Rietveld 408576698